bpo-41718: subprocess imports grp and pwd on demand#24987
Merged
vstinner merged 1 commit intopython:masterfrom Mar 23, 2021
vstinner:grp_pwd
Merged
bpo-41718: subprocess imports grp and pwd on demand#24987vstinner merged 1 commit intopython:masterfrom vstinner:grp_pwd
vstinner merged 1 commit intopython:masterfrom
vstinner:grp_pwd
Conversation
The shutil and subprocess modules now only import the grp and pwd modules when they are needed, which is not the case by default in subprocess.
Member
Author
|
@gpshead: Would you mind to review this change? Does it sound worth it to you? I have no idea if this change has an impact on subprocess.Popen performance when the user/group options are used. An import should be efficient if it's already in sys.modules. |
gpshead
approved these changes
Mar 23, 2021
Member
Author
|
Thanks for the review @gpshead ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shutil and subprocess modules now only import the grp and pwd
modules when they are needed, which is not the case by default in
subprocess.
https://bugs.python.org/issue41718