Skip to content

AC: Update unsupported_special_methods#24956

Merged
corona10 merged 1 commit intopython:masterfrom
corona10:ac_fix
Mar 25, 2021
Merged

AC: Update unsupported_special_methods#24956
corona10 merged 1 commit intopython:masterfrom
corona10:ac_fix

Conversation

@corona10
Copy link
Copy Markdown
Member

@corona10 corona10 commented Mar 21, 2021 •
edited
Loading

cpython/Tools/clinic/clinic.py

Lines 4230 to 4241 in 8fba952

if fields[-1] == '__new__':
if (self.kind != CLASS_METHOD) or (not cls):
fail("__new__ must be a class method!")
self.kind = METHOD_NEW
elif fields[-1] == '__init__':
if (self.kind != CALLABLE) or (not cls):
fail("__init__ must be a normal method, not a class or static method!")
self.kind = METHOD_INIT
if not return_converter:
return_converter = init_return_converter()
elif fields[-1] in unsupported_special_methods:
fail(fields[-1] + " is a special method and cannot be converted to Argument Clinic! (Yet.)")

  1. AC already supports __new__ method, but the __new__ is still existed in the unsupported_special_methods
  2. The reason that this code does not raise any bug is that __new__ already satisfies the first if statement, so there was no chance to meet the last if statement.
  3. To prevent non-updated unsupported_special_methods, I move up the last if statement to the above of the first statement. by doing this next author can detect unsupported_special_methods is updated or not

corona10
corona10 commented Mar 21, 2021
View reviewed changes
Tools/clinic/clinic.py
module, cls = self.clinic._module_and_class(fields)

fields = full_name.split('.')
if fields[-1] in unsupported_special_methods:
Copy link
Copy Markdown
Member Author

@corona10 corona10 Mar 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear reviewers,
This change is intended to early detect the consistency of unsupported_special_methods.

@corona10
Copy link
Copy Markdown
Member Author

corona10 commented Mar 24, 2021

@pablogsal @serhiy-storchaka @vstinner gentle ping

vstinner
vstinner approved these changes Mar 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10
Copy link
Copy Markdown
Member Author

corona10 commented Mar 25, 2021

@vstinner Thank you!

@corona10 corona10 merged commit df9ade9 into python:master Mar 25, 2021
@corona10 corona10 deleted the ac_fix branch March 25, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10 @vstinner @the-knights-who-say-ni @bedevere-bot