Skip to content

Doc: io: Remove "In-memory streams" section#24927

Merged
methane merged 2 commits intopython:masterfrom
methane:doc-io
Mar 25, 2021
Merged

Doc: io: Remove "In-memory streams" section#24927
methane merged 2 commits intopython:masterfrom
methane:doc-io

Conversation

@methane
Copy link
Copy Markdown
Member

@methane methane commented Mar 18, 2021 •
edited
Loading

This section looks be misplaced. It was written in b530e14.

@methane methane requested a review from pitrou March 18, 2021 22:30
pitrou
pitrou requested changes Mar 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overview describes the three separate classes of IO: raw, buffered binary, and text. "In-memory streams" are not a fourth kind of IO, so they don't belong in the overview.

We may want to move them into the "Class hierarchy" section however.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 20, 2021

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@methane
Copy link
Copy Markdown
Member Author

methane commented Mar 21, 2021

BytesIO is in "Buffered Streams" section (because it inherits BufferedIOBase), and StringIO is in "Text I/O" section.

May I just remove this "In-memory streams" section?

@methane methane changed the title Doc: io: Move In-memory streams section into overview section. Doc: io: Remove "In-memory streams" section Mar 21, 2021
@methane methane merged commit b045cda into python:master Mar 25, 2021
@methane methane deleted the doc-io branch March 25, 2021 07:23
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Mar 25, 2021

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 25, 2021

GH-25017 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2021
@methane @miss-islington
Doc: io: Remove "In-memory streams" section (pythonGH-24927)
808c087 
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 25, 2021

GH-25018 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2021
@methane @miss-islington
Doc: io: Remove "In-memory streams" section (pythonGH-24927)
15b5fa3 
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull request Apr 1, 2021
@miss-islington @methane
Doc: io: Remove "In-memory streams" section (GH-24927)
4ea8b24 
(cherry picked from commit b045cda)
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull request Apr 1, 2021
@miss-islington @methane
Doc: io: Remove "In-memory streams" section (GH-24927)
244fa23 
(cherry picked from commit b045cda)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou requested changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@methane @bedevere-bot @miss-islington @pitrou @the-knights-who-say-ni