Skip to content

[3.9] bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118)#24832

Merged
orsenthil merged 1 commit into
python:3.9from
miss-islington:backport-7591d94-3.9
Mar 13, 2021
Merged

[3.9] bpo-27820: Fix AUTH LOGIN logic in smtplib.SMTP (GH-24118)#24832
orsenthil merged 1 commit into
python:3.9from
miss-islington:backport-7591d94-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 12, 2021

Copy link
Copy Markdown
Contributor
  • Fix auth_login logic (bpo-27820)

  • Also fix a longstanding bug in the SimSMTPChannel.found_terminator() method that causes inability to test
    SMTP AUTH with initial_response_ok=False.
    (cherry picked from commit 7591d94)

Co-authored-by: Pandu E POLUAN pepoluan@gmail.com

https://bugs.python.org/issue27820

* Fix auth_login logic (bpo-27820)

* Also fix a longstanding bug in the SimSMTPChannel.found_terminator() method that causes inability to test
SMTP AUTH with initial_response_ok=False.
(cherry picked from commit 7591d94)

Co-authored-by: Pandu E POLUAN <pepoluan@gmail.com>

@orsenthil orsenthil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orsenthil
orsenthil merged commit 32717b9 into python:3.9 Mar 13, 2021
@bedevere-bot

Copy link
Copy Markdown

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
miss-islington deleted the backport-7591d94-3.9 branch March 13, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants