bpo-43332: Buffer proxy connection setup packets before sending.#24780
Merged
gpshead merged 3 commits intoMar 8, 2021
Conversation
We now buffer the CONNECT request + tunnel HTTP headers into a single send call. This prevents the OS from generating multiple network packets for connection setup when not necessary, improving efficiency.
gpshead
added
type-bug
orsenthil
reviewed
Mar 7, 2021
orsenthil
reviewed
Mar 8, 2021
| self.assertNotIn(b'Host: proxy.com', self.conn.sock.data) | ||
|
|
||
| def test_tunnel_connect_single_send_connection_setup(self): | ||
| """Regresstion test for https://bugs.python.org/issue43332.""" |
Member
There was a problem hiding this comment.
Suggested change
| """Regresstion test for https://bugs.python.org/issue43332.""" | |
| """Regression test for https://bugs.python.org/issue43332.""" |
orsenthil
reviewed
Mar 8, 2021
orsenthil
approved these changes
Mar 8, 2021
orsenthil
left a comment
orsenthil
left a comment
Member
There was a problem hiding this comment.
LGTM.
I have a review comment for the test which you can choose to address.
Contributor
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 8, 2021
…honGH-24780) We now buffer the CONNECT request + tunnel HTTP headers into a single send call. This prevents the OS from generating multiple network packets for connection setup when not necessary, improving efficiency. (cherry picked from commit c25910a) Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-24783 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 8, 2021
…24780) We now buffer the CONNECT request + tunnel HTTP headers into a single send call. This prevents the OS from generating multiple network packets for connection setup when not necessary, improving efficiency. (cherry picked from commit c25910a) Co-authored-by: Gregory P. Smith <greg@krypto.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now buffer the CONNECT request + tunnel HTTP headers into a single
send call. This prevents the OS from generating multiple network
packets for connection setup when not necessary, improving efficiency.
https://bugs.python.org/issue43332