Skip to content

bpo-43399: Fix ElementTree.extend not working on iterators#24751

Merged
serhiy-storchaka merged 3 commits intopython:masterfrom
alexprengere:fix-issue-43399
Mar 30, 2021
Merged

bpo-43399: Fix ElementTree.extend not working on iterators#24751
serhiy-storchaka merged 3 commits intopython:masterfrom
alexprengere:fix-issue-43399

Conversation

@alexprengere
Copy link
Copy Markdown
Contributor

@alexprengere alexprengere commented Mar 4, 2021 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Mar 4, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@alexprengere

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@tirkarthi
Copy link
Copy Markdown
Member

tirkarthi commented Mar 4, 2021

Please add a news entry for the change.

serhiy-storchaka
serhiy-storchaka approved these changes Mar 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 51a85dd into python:master Mar 30, 2021
@serhiy-storchaka serhiy-storchaka added needs backport to 3.8 type-bug An unexpected behavior, bug, or error labels Mar 30, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Mar 30, 2021

Thanks @alexprengere for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Mar 30, 2021

Thanks @alexprengere for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 30, 2021

GH-25101 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2021
@alexprengere @miss-islington
bpo-43399: Fix ElementTree.extend not working on iterators (pythonGH-…
734ba67 
…24751)

(cherry picked from commit 51a85dd)

Co-authored-by: Alex Prengère <2138730+alexprengere@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2021
@alexprengere @miss-islington
bpo-43399: Fix ElementTree.extend not working on iterators (pythonGH-…
5375551 
…24751)

(cherry picked from commit 51a85dd)

Co-authored-by: Alex Prengère <2138730+alexprengere@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 30, 2021

GH-25102 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Mar 30, 2021
@miss-islington @alexprengere
bpo-43399: Fix ElementTree.extend not working on iterators (GH-24751)
c1079cd 
(cherry picked from commit 51a85dd)

Co-authored-by: Alex Prengère <2138730+alexprengere@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 30, 2021
@miss-islington @alexprengere
bpo-43399: Fix ElementTree.extend not working on iterators (GH-24751)
b500bd8 
(cherry picked from commit 51a85dd)

Co-authored-by: Alex Prengère <2138730+alexprengere@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scoder scoder scoder approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexprengere @the-knights-who-say-ni @tirkarthi @miss-islington @bedevere-bot @scoder @serhiy-storchaka