bpo-43368: Fix fetching empty bytes on SQLite.#24706
Merged
Merged
Conversation
Contributor
|
This requires a NEWS item, since it's a regression in an official release. |
Contributor
Author
Added. |
erlend-aasland
approved these changes
Mar 2, 2021
erlend-aasland
left a comment
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
LGTM w/minor nitpicks. I'll add error handling in a separate PR. Thanks for spotting this!
Contributor
Author
|
@erlend-aasland Thanks for reviews 👍 |
berkerpeksag
approved these changes
Mar 3, 2021
berkerpeksag
left a comment
berkerpeksag
left a comment
Member
There was a problem hiding this comment.
LGTM! I'll rerun tests since one of the required ones was failed.
Member
|
I thought it was a flaky test, but turns out master is broken. I'll merge once master is green. |
Contributor
Author
|
@berkerpeksag Thanks 👍 |
Regression in 47feb1f.
Contributor
Author
|
Rebased from master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-43368
Regression in 47feb1f (bpo-43249)
https://bugs.python.org/issue43368