Skip to content

gh-86650: get_obs_local_part() fails to handle empty local part #24669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZackerySpytz wants to merge 2 commits into from
Closed

gh-86650: get_obs_local_part() fails to handle empty local part #24669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a47591
bpo-42484: get_obs_local_part() fails to handle empty local part
ZackerySpytz Feb 28, 2021
e63a312
Merge branch 'main' into bpo-42484-email-get_obs_local_part
arhadthedev Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/email/_header_value_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,8 @@ def get_obs_local_part(value):
raise
token, value = get_cfws(value)
obs_local_part.append(token)
if not obs_local_part:
return obs_local_part, value
if (obs_local_part[0].token_type == 'dot' or
obs_local_part[0].token_type=='cfws' and
obs_local_part[1].token_type=='dot'):
Expand Down
5 changes: 5 additions & 0 deletions Lib/test/test_email/test_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,11 @@ def test_str_defaults_to_policy_max_line_length(self):
m = self._str_msg('Subject: long line' + ' ab'*50 + '\n\n')
self.assertEqual(len(str(m).strip().splitlines()), 3)

def test_invalid_message_id_exception(self):
m = EmailMessage()
m['Message-ID'] = '<[>'
self.assertEqual(str(m), 'Message-ID: <\n\n')

def test_str_defaults_to_utf8(self):
m = EmailMessage()
m['Subject'] = 'unicöde'
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2021-02-28-09-39-13.bpo-42484.yypl40.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix an exception in :class:`email.message.EmailMessage` when setting an
invalid Message-ID.