Skip to content

bpo-43288: Fix test_importlib test to correctly skip #24612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nascheme merged 1 commit into from
Feb 21, 2021
+6 −0
Merged

bpo-43288: Fix test_importlib test to correctly skip #24612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/test/test_importlib/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import tempfile
import textwrap
import contextlib
import unittest

from test.support.os_helper import FS_NONASCII
from typing import Dict, Union
Expand Down Expand Up @@ -219,6 +220,9 @@ def setUp(self):
self.fixtures.enter_context(tempdir_as_cwd())
build_files(self.files)

def skip(self, reason):
raise unittest.SkipTest(reason)


def build_files(file_defs, prefix=pathlib.Path()):
"""Build a set of files/directories, as described by the
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2021-02-21-11-11-53.bpo-43288.LfTvL-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix test_importlib to correctly skip Unicode file tests if the fileystem
does not support them.