Skip to content

bpo-43258: Fix sqlite3 UDF callback scoping #24574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 2 commits into from
Feb 19, 2021
+4 −2
Merged

bpo-43258: Fix sqlite3 UDF callback scoping #24574

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c371d7
_pysqlite_final_callback should be static
Feb 18, 2021
d924805
_pysqlite_func_callback should be static
Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Modules/_sqlite/connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,8 @@ PyObject* _pysqlite_build_py_params(sqlite3_context *context, int argc, sqlite3_
return args;
}

void _pysqlite_func_callback(sqlite3_context* context, int argc, sqlite3_value** argv)
static void
_pysqlite_func_callback(sqlite3_context *context, int argc, sqlite3_value **argv)
{
PyObject* args;
PyObject* py_func;
Expand Down Expand Up @@ -696,7 +697,8 @@ static void _pysqlite_step_callback(sqlite3_context *context, int argc, sqlite3_
PyGILState_Release(threadstate);
}

void _pysqlite_final_callback(sqlite3_context* context)
static void
_pysqlite_final_callback(sqlite3_context *context)
{
PyObject* function_result;
PyObject** aggregate_instance;
Expand Down