Skip to content

bpo-43125: Fix: return expected type (str), not original value (bytes) in email/base64mime.py::body_encode#24476

Merged
corona10 merged 5 commits intopython:masterfrom
gst:43125_solution
Mar 30, 2021
Merged

bpo-43125: Fix: return expected type (str), not original value (bytes) in email/base64mime.py::body_encode#24476
corona10 merged 5 commits intopython:masterfrom
gst:43125_solution

Conversation

@gst
Copy link
Copy Markdown
Contributor

@gst gst commented Feb 7, 2021 •
edited
Loading

All in title.

the utility function Lib/email/base64mime.py::body_encode :

def body_encode(s, maxlinelen=76, eol=NL):

returns its given input if this one evaluates to False. This is bad. given the expected input is bytes but the expected output is str. ( return EMPTYSTRING.join(encvec) ).

The fix looks obvious: return an empty string instead of the original object (whatever type it might be).

https://bugs.python.org/issue43125

@gst gst requested a review from a team as a code owner February 7, 2021 18:40
@gst gst changed the title bpo-43125: Fix: return expected type (str), not original value (bytes) bpo-43125: Fix: return expected type (str), not original value (bytes) in email/base64mime.py::body_encode Feb 9, 2021
@gst
Copy link
Copy Markdown
Contributor Author

gst commented Feb 9, 2021

@matrixise

my first PR ! :)

what's next ?

corona10
corona10 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
but @serhiy-storchaka Can you please take a look also?

corona10
corona10 reviewed Feb 22, 2021
View reviewed changes
corona10
corona10 reviewed Feb 22, 2021
View reviewed changes
@gst
Copy link
Copy Markdown
Contributor Author

gst commented Mar 3, 2021

@corona10 @serhiy-storchaka

I made the changes. what's next step ?

matrixise
matrixise requested changes Mar 8, 2021
View reviewed changes
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 8, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@gst
Copy link
Copy Markdown
Contributor Author

gst commented Mar 10, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Mar 10, 2021

Thanks for making the requested changes!

@matrixise, @corona10: please review the changes made to this pull request.

@gst
Copy link
Copy Markdown
Contributor Author

gst commented Mar 19, 2021

@matrixise @corona10 ?

corona10
corona10 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit cf35e05 into python:master Mar 30, 2021
@gst gst deleted the 43125_solution branch May 21, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@matrixise matrixise Awaiting requested review from matrixise

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gst @bedevere-bot @matrixise @corona10 @the-knights-who-say-ni