[3.8] bpo-41748: Handles unquoted attributes with commas (GH-24072)#24416
Merged
Conversation
* bpo-41748: Adds tests for unquoted attributes with comma * bpo-41748: Handles unquoted attributes with comma * bpo-41748: Addresses review comments * bpo-41748: Addresses review comments * Adds more test cases * Simplifies the regex for handling spaces * bpo-41748: Moves attributes tests under the right class * bpo-41748: Addresses review about duplicate attributes * bpo-41748: Adds NEWS.d entry for this patch (cherry picked from commit 9eb11a1) Co-authored-by: Karl Dubost <karl+github@la-grange.net>
Contributor
Author
|
@karlcow and @ezio-melotti: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@karlcow and @ezio-melotti: Status check is done, and it's a success ✅ . |
ezio-melotti
approved these changes
Feb 1, 2021
Contributor
Author
|
@karlcow and @ezio-melotti: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-41748: Adds tests for unquoted attributes with comma
bpo-41748: Handles unquoted attributes with comma
bpo-41748: Addresses review comments
bpo-41748: Addresses review comments
Adds more test cases
Simplifies the regex for handling spaces
bpo-41748: Moves attributes tests under the right class
bpo-41748: Addresses review about duplicate attributes
bpo-41748: Adds NEWS.d entry for this patch
(cherry picked from commit 9eb11a1)
Co-authored-by: Karl Dubost karl+github@la-grange.net
https://bugs.python.org/issue41748