Skip to content

bpo-42960: resources module, adding RLIMIT_KQUEUES constant from FreeBSD#24251

Merged
vstinner merged 2 commits into
python:masterfrom
devnexen:rlimit_fbsd_upd
Feb 18, 2021
Merged

bpo-42960: resources module, adding RLIMIT_KQUEUES constant from FreeBSD#24251
vstinner merged 2 commits into
python:masterfrom
devnexen:rlimit_fbsd_upd

Conversation

@devnexen

@devnexen devnexen commented Jan 18, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@devnexen devnexen changed the title resources module, adding RLIMIT_KQUEUES constant from FreeBSD bpo-42960: resources module, adding RLIMIT_KQUEUES constant from FreeBSD Jan 18, 2021
@github-actions

github-actions Bot commented Feb 18, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 18, 2021
@devnexen

devnexen commented Feb 18, 2021

Copy link
Copy Markdown
Contributor Author

@vstinner

vstinner
vstinner reviewed Feb 18, 2021
View reviewed changes
Comment thread Doc/library/resource.rst Outdated

@vstinner vstinner Feb 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the definition from the FreeBSD manual page:

"The maximum number of kqueues this user id is allowed to create."

=> "is allowed to create" rather than "created".

Comment thread Misc/NEWS.d/next/Library/2021-01-18-21-07-20.bpo-42960.a7Dote.rst Outdated

@vstinner vstinner Feb 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Adds RLIMIT_KQUEUES constant from FreeBSD to the resources module
Adds :data:`resource.RLIMIT_KQUEUES` constant from FreeBSD to the :mod:`resource` module.

vstinner
vstinner reviewed Feb 18, 2021
View reviewed changes
Comment thread Doc/library/resource.rst Outdated

@vstinner vstinner Feb 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still different than the sentence from the FreeBSD manual page, this sentence sounds wrong to me.

ambv
ambv requested changes Feb 18, 2021
View reviewed changes

@ambv ambv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "resources" module. Victor gave you a correct code suggestion you could have applied.

@bedevere-bot

bedevere-bot commented Feb 18, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner reviewed Feb 18, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2021-01-18-21-07-20.bpo-42960.a7Dote.rst Outdated

@vstinner vstinner Feb 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put a trailing dot to your sentence (and fix the typo in the module name)

vstinner
vstinner approved these changes Feb 18, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 7be00ee into python:master Feb 18, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@devnexen @adorilson
bpo-42960: Add resource.RLIMIT_KQUEUES constant from FreeBSD (pythonG…
7fb1192 
…H-24251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv requested changes

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devnexen @bedevere-bot @ambv @vstinner @the-knights-who-say-ni