bpo-42934: use TracebackException's new compact param in unittest.Tes…#24221
Merged
gvanrossum merged 1 commit intopython:masterfrom Jan 15, 2021
Merged
bpo-42934: use TracebackException's new compact param in unittest.Tes…#24221gvanrossum merged 1 commit intopython:masterfrom
gvanrossum merged 1 commit intopython:masterfrom
Conversation
gvanrossum
approved these changes
Jan 15, 2021
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Did you measure the time savings?
Member
Author
|
No. How would we do that? We can probably create a pathological example where the difference is exponential (a complete binary tree of exceptions). |
Member
Author
|
Ah you mean the time for a buildbot test run? |
Member
|
It wasn’t a very serious question, let’s not worry about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tResult
https://bugs.python.org/issue42934