Skip to content

[doc] Fix addCleanupClass -> addClassCleanup typo#24194

Merged
tirkarthi merged 2 commits into
python:masterfrom
Conchylicultor:patch-1
Jan 20, 2021
Merged

[doc] Fix addCleanupClass -> addClassCleanup typo#24194
tirkarthi merged 2 commits into
python:masterfrom
Conchylicultor:patch-1

Conversation

@Conchylicultor

Copy link
Copy Markdown
Contributor

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is a similar typo of doCleanupsClass -> doClassCleanups in https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups

@Conchylicultor Conchylicultor changed the title [doc] Fix addCleanupClass -> addCleanupClass typo [doc] Fix addCleanupClass -> addClassCleanup typo Jan 12, 2021
@Conchylicultor

Copy link
Copy Markdown
Contributor Author

I guess there is a similar typo of doCleanupsClass -> doClassCleanups in https://docs.python.org/3/library/unittest.html#unittest.TestCase.doClassCleanups

Done

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @Conchylicultor for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-24267 is a backport of this pull request to the 3.9 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-24268 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2021
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
miss-islington added a commit that referenced this pull request Jan 20, 2021
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
miss-islington added a commit that referenced this pull request Mar 14, 2021
* addCleanupClass  -> addClassCleanup
* doCleanupsClass -> doClassCleanups
(cherry picked from commit e0e398e)

Co-authored-by: Conchylicultor <etiennefg.pot@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants