bpo-41748: Handles unquoted attributes with commas by karlcow · Pull Request #24072 · python/cpython

karlcow · 2021-01-03T08:52:12Z

data:text/html,<!doctype html><div class=bar,baz=asd>text</div>
serialized as <div class="bar,baz=asd">text</div>

but

data:text/html,<!doctype html><div class=bar ,baz=asd>text</div>
serialized as <div class="bar" ,baz="asd">text</div>

As discussed in https://bugs.python.org/issue41748

https://bugs.python.org/issue41748

Automerge-Triggered-By: GH:ezio-melotti

bedevere-bot · 2021-01-03T09:08:04Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

karlcow · 2021-01-03T12:03:47Z

I have made the requested changes; please review again

bedevere-bot · 2021-01-03T12:03:50Z

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

bedevere-bot · 2021-01-04T05:12:09Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

* Adds more test cases * Simplifies the regex for handling spaces

karlcow · 2021-01-04T08:02:02Z

I have made the requested changes; please review again

bedevere-bot · 2021-01-04T08:02:05Z

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

ezio-melotti

A couple minor comments, in addition to the comment I left in the main conversation.
Also remember to add a NEWS entry to the PR.

karlcow · 2021-01-06T08:23:15Z

@ezio-melotti done. I have made the requested changes; please review again

bedevere-bot · 2021-01-06T08:23:18Z

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

ezio-melotti · 2021-01-06T08:48:40Z

Thanks for addressing all the comments, we only need a NEWS entry and then I can merge the PR.
You can use blurb or blurb-it to add one (see the devguide for more info).

karlcow · 2021-01-06T12:40:55Z

@ezio-melotti NEWS.d entry added. Thanks for the review and the help along this PR.

karlcow · 2021-01-12T07:16:17Z

I have made the requested changes; please review again

bedevere-bot · 2021-01-12T07:16:19Z

Thanks for making the requested changes!

@ezio-melotti: please review the changes made to this pull request.

miss-islington · 2021-02-01T20:32:53Z

Thanks @karlcow for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

bedevere-bot · 2021-02-01T20:32:53Z

@ezio-melotti: Please replace # with GH- in the commit message next time. Thanks!

* bpo-41748: Adds tests for unquoted attributes with comma * bpo-41748: Handles unquoted attributes with comma * bpo-41748: Addresses review comments * bpo-41748: Addresses review comments * Adds more test cases * Simplifies the regex for handling spaces * bpo-41748: Moves attributes tests under the right class * bpo-41748: Addresses review about duplicate attributes * bpo-41748: Adds NEWS.d entry for this patch (cherry picked from commit 9eb11a1) Co-authored-by: Karl Dubost <karl+github@la-grange.net>

bedevere-bot · 2021-02-01T20:33:13Z

GH-24415 is a backport of this pull request to the 3.9 branch.

* bpo-41748: Adds tests for unquoted attributes with comma * bpo-41748: Handles unquoted attributes with comma * bpo-41748: Addresses review comments * bpo-41748: Addresses review comments * Adds more test cases * Simplifies the regex for handling spaces * bpo-41748: Moves attributes tests under the right class * bpo-41748: Addresses review about duplicate attributes * bpo-41748: Adds NEWS.d entry for this patch (cherry picked from commit 9eb11a1) Co-authored-by: Karl Dubost <karl+github@la-grange.net>

bedevere-bot · 2021-02-01T20:33:25Z

GH-24416 is a backport of this pull request to the 3.8 branch.

* bpo-41748: Adds tests for unquoted attributes with comma * bpo-41748: Handles unquoted attributes with comma * bpo-41748: Addresses review comments * bpo-41748: Addresses review comments * Adds more test cases * Simplifies the regex for handling spaces * bpo-41748: Moves attributes tests under the right class * bpo-41748: Addresses review about duplicate attributes * bpo-41748: Adds NEWS.d entry for this patch (cherry picked from commit 9eb11a1) Co-authored-by: Karl Dubost <karl+github@la-grange.net>

* bpo-41748: Adds tests for unquoted attributes with comma * bpo-41748: Handles unquoted attributes with comma * bpo-41748: Addresses review comments * bpo-41748: Addresses review comments * Adds more test cases * Simplifies the regex for handling spaces * bpo-41748: Moves attributes tests under the right class * bpo-41748: Addresses review about duplicate attributes * bpo-41748: Adds NEWS.d entry for this patch

karlcow added 2 commits January 3, 2021 17:46

bpo-41748: Adds tests for unquoted attributes with comma

d53633d

bpo-41748: Handles unquoted attributes with comma

83e2b6b

karlcow requested a review from ezio-melotti as a code owner January 3, 2021 08:52

the-knights-who-say-ni added the CLA signed label Jan 3, 2021

bedevere-bot added the awaiting review label Jan 3, 2021

ezio-melotti requested changes Jan 3, 2021

View reviewed changes

Comment thread Lib/html/parser.py Outdated

bedevere-bot added awaiting changes and removed awaiting review labels Jan 3, 2021

ezio-melotti self-assigned this Jan 3, 2021

bpo-41748: Addresses review comments

035bafb

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 3, 2021

bedevere-bot requested a review from ezio-melotti January 3, 2021 12:03

ezio-melotti requested changes Jan 4, 2021

View reviewed changes

Comment thread Lib/html/parser.py Outdated

Comment thread Lib/test/test_htmlparser.py Outdated

bedevere-bot added awaiting changes and removed awaiting change review labels Jan 4, 2021

karlcow added 3 commits January 4, 2021 15:30

Merge branch 'master' of github.com:python/cpython into bpo-41748

8ca5569

bpo-41748: Addresses review comments

4f1fa6d

* Adds more test cases * Simplifies the regex for handling spaces

bpo-41748: Moves attributes tests under the right class

2e8c3f5

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 4, 2021

bedevere-bot requested a review from ezio-melotti January 4, 2021 08:02

ezio-melotti requested changes Jan 6, 2021

View reviewed changes

Comment thread Lib/html/parser.py Outdated

Comment thread Lib/test/test_htmlparser.py

bedevere-bot removed the awaiting change review label Jan 6, 2021

bpo-41748: Addresses review about duplicate attributes

1cee874

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 6, 2021

bedevere-bot requested a review from ezio-melotti January 6, 2021 08:23

bpo-41748: Adds NEWS.d entry for this patch

0b37ebf

ezio-melotti added 🤖 automerge type-bug An unexpected behavior, bug, or error labels Feb 1, 2021

ezio-melotti merged commit 9eb11a1 into python:master Feb 1, 2021

bedevere-bot removed the awaiting change review label Feb 1, 2021

bedevere-bot removed the needs backport to 3.9 label Feb 1, 2021

bedevere-bot removed the needs backport to 3.8 label Feb 1, 2021

nowaskyjr mannequin mentioned this pull request Apr 10, 2022

HTMLParser: comma in attribute values with/without space #85914

Closed

Uh oh!

Uh oh!

Conversation

karlcow commented Jan 3, 2021 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 3, 2021

Uh oh!

karlcow commented Jan 3, 2021

Uh oh!

bedevere-bot commented Jan 3, 2021

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 4, 2021

Uh oh!

karlcow commented Jan 4, 2021

Uh oh!

bedevere-bot commented Jan 4, 2021

Uh oh!

ezio-melotti left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

karlcow commented Jan 6, 2021

Uh oh!

bedevere-bot commented Jan 6, 2021

Uh oh!

ezio-melotti commented Jan 6, 2021

Uh oh!

karlcow commented Jan 6, 2021

Uh oh!

karlcow commented Jan 12, 2021

Uh oh!

bedevere-bot commented Jan 12, 2021

Uh oh!

miss-islington commented Feb 1, 2021

Uh oh!

bedevere-bot commented Feb 1, 2021

Uh oh!

bedevere-bot commented Feb 1, 2021

Uh oh!

bedevere-bot commented Feb 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

karlcow commented Jan 3, 2021 •

edited by miss-islington

Loading