bpo-42808: Add PyType_Type.tp_vectorcall for type(obj) performance#24058
Conversation
| if (!_PyArg_NoKwnames("type", kwnames)) { | ||
| return NULL; | ||
| } | ||
| PyObject *tp = (PyObject *)Py_TYPE(args[0]); |
There was a problem hiding this comment.
nit: we can use Py_NewRef() in this case?
|
This PR is stale because it has been open for 30 days with no activity. |
|
@markshannon As code owner, do you think there is any worth to this? |
|
Yes, I do. |
|
LGTM. Let's rerun the tests before merging as they are a month old. |
|
Any update on this? I'm seeing some nice benchmarks: |
|
@markshannon Any update on this? |
corona10
left a comment
There was a problem hiding this comment.
LGTM I will merge this PR after tests are passed ;)
cc @markshannon
|
|
Buildbot failure is unrelated to this PR |
https://bugs.python.org/issue42808