bpo-42778: Add follow_symlinks optional argument to os.path and pathlib samefile methods#23996
Closed
rrhodes wants to merge 1 commit into
Closed
bpo-42778: Add follow_symlinks optional argument to os.path and pathlib samefile methods#23996rrhodes wants to merge 1 commit into
follow_symlinks optional argument to os.path and pathlib samefile methods#23996rrhodes wants to merge 1 commit into
Conversation
rrhodes
force-pushed
the
fix-issue-42778
branch
from
ff46ba2 to
60dfe3e
Compare
rrhodes
force-pushed
the
fix-issue-42778
branch
from
2899720 to
d694ea4
Compare
Contributor
Author
|
Hi @corona10, sorry to ping you here out the blue but you've given great feedback in the past for other PRs I've opened. Any idea who should be requested to review the changes here? |
Contributor
Author
|
Hi @serhiy-storchaka, apologies but I'll also ping you here since you've been great help for my previous contributions too. Any idea who should review these changes? |
Contributor
Author
|
Hi @pxinwr, @ypankovych, looks like you two were both recent contributors to files affected by this change. Either of you happy to review these changes for me please? |
ypankovych
approved these changes
Jan 19, 2021
Contributor
|
LGTM |
Contributor
Author
|
It appears this functionality is not required. There are alternative ways to achieve intended behavior with other methods. Closing this now, but will keep the branch open in case appetite grows for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add
follow_symlinksoptional argument to os.path and pathlibsamefilemethods.Why?
To allow users to compare files without following symlinks. By default symlinks will be followed for backward compatibility.
https://bugs.python.org/issue42778