Skip to content

bpo-27794: Add name attribute to property class#23967

Merged
rhettinger merged 8 commits into
python:masterfrom
uriyyo:fix-issue-27794
Dec 30, 2020
Merged

bpo-27794: Add name attribute to property class#23967
rhettinger merged 8 commits into
python:masterfrom
uriyyo:fix-issue-27794

Conversation

@uriyyo

@uriyyo uriyyo commented Dec 27, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@rhettinger rhettinger self-assigned this Dec 27, 2020
rhettinger
rhettinger reviewed Dec 28, 2020
View reviewed changes
Comment thread Objects/descrobject.c Outdated
rhettinger
rhettinger reviewed Dec 28, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-12-27-18-07-43.bpo-27794.sxgfGi.rst Outdated
rhettinger
rhettinger requested changes Dec 28, 2020
View reviewed changes
Comment thread Doc/howto/descriptor.rst Outdated
Comment thread Doc/howto/descriptor.rst Outdated
Comment thread Doc/howto/descriptor.rst Outdated
@bedevere-bot

bedevere-bot commented Dec 28, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

rhettinger
rhettinger reviewed Dec 28, 2020
View reviewed changes
Comment thread Objects/descrobject.c
rhettinger
rhettinger reviewed Dec 28, 2020
View reviewed changes
Comment thread Objects/descrobject.c
@uriyyo

uriyyo commented Dec 28, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Dec 28, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

rhettinger
rhettinger requested changes Dec 29, 2020
View reviewed changes
Comment thread Doc/howto/descriptor.rst Outdated
Comment thread Objects/descrobject.c Outdated
@bedevere-bot

bedevere-bot commented Dec 29, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo

uriyyo commented Dec 29, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Dec 29, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

rhettinger
rhettinger requested changes Dec 29, 2020
View reviewed changes
Comment thread Objects/descrobject.c Outdated
Comment thread Doc/howto/descriptor.rst Outdated
Comment thread Doc/howto/descriptor.rst Outdated
Comment thread Objects/descrobject.c Outdated
Comment thread Objects/descrobject.c Outdated
@bedevere-bot

bedevere-bot commented Dec 29, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@uriyyo

uriyyo commented Dec 29, 2020

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Dec 29, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@rhettinger
rhettinger merged commit c56387f into python:master Dec 30, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@uriyyo @adorilson
bpo-27794: Add name attribute to property class (pythonGH-23967)
9379dc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@rhettinger rhettinger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@uriyyo @bedevere-bot @rhettinger @the-knights-who-say-ni