I've updated the branch to the revert of PEP 563.

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

ch I don't understand fully since the point of this is to drop side effects like [][print('Hi!')]: int

No, it is to drop the side effect of the annotation part not the target part. See https://bugs.python.org/issue42737#msg383819

ch I don't understand fully since the point of this is to drop side effects like [][print('Hi!')]: int

No, it is to drop the side effect of the annotation part not the target part. See https://bugs.python.org/issue42737#msg383819

Apologies, I have copied a bad example from the issue. But shoudn't we add some test checking that either we don't generate bytecode or that some side effect call or similar is never triggered. Unfortunately I don't see how the syntaxError is relevant in that test

Apologies, I have copied a bad example from the issue. But shoudn't we add some test checking that either we don't generate bytecode or that some side effect call or similar is never triggered. Unfortunately I don't see how the syntaxError is relevant in that test

The previous version was testing those, though since the test_future suite checks everything out with the new additions to the template it is all verified. And the syntax error is just to ensure that compiler stills checks everything out

Fantastic, thanks for explaining!

@isidentical: Status check is done, and it's a failure ❌ .