Skip to content

bpo-42692: fix __builtin_available check on older compilers #23873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 2 commits into from
Jan 4, 2021
Merged

bpo-42692: fix __builtin_available check on older compilers #23873

miss-islington merged 2 commits into from
Jan 4, 2021

Conversation

@jmroot
Copy link
Contributor

@jmroot jmroot commented Dec 20, 2020 •
edited by miss-islington
Loading

A compiler that doesn't define __has_builtin will error out when it is
used on the same line as the check for it.

https://bugs.python.org/issue42692

Automerge-Triggered-By: GH:ronaldoussoren

@jmroot
bpo-42692: fix __builtin_available check on older compilers
1622408 
A compiler that doesn't define __has_builtin will error out when it is
used on the same line as the check for it.
@jmroot jmroot mentioned this pull request Dec 20, 2020
Merged
ronaldoussoren
ronaldoussoren approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@miss-islington
Copy link
Contributor

miss-islington commented Jan 4, 2021

@jmroot: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

miss-islington commented Jan 4, 2021

@jmroot: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Jan 4, 2021

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

miss-islington commented Jan 4, 2021

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks are expected..

@miss-islington
Copy link
Contributor

miss-islington commented Jan 4, 2021

@jmroot: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit df21f50 into python:master Jan 4, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jan 4, 2021

Thanks @jmroot for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2021
@jmroot @miss-islington
bpo-42692: fix __builtin_available check on older compilers (pythonGH…
754c06f 
…-23873)

A compiler that doesn't define `__has_builtin` will error out when it is
used on the same line as the check for it.

Automerge-Triggered-By: GH:ronaldoussoren
(cherry picked from commit df21f50)

Co-authored-by: Joshua Root <jmr@macports.org>
@bedevere-bot
Copy link

bedevere-bot commented Jan 4, 2021

GH-24090 is a backport of this pull request to the 3.9 branch.

ned-deily pushed a commit that referenced this pull request Jan 4, 2021
@miss-islington @jmroot
bpo-42692: fix __builtin_available check on older compilers (GH-23873) (
eedeaef 
GH-24090)

A compiler that doesn't define `__has_builtin` will error out when it is
used on the same line as the check for it.

Automerge-Triggered-By: GH:ronaldoussoren
(cherry picked from commit df21f50)

Co-authored-by: Joshua Root <jmr@macports.org>
@jmroot jmroot deleted the builtin-available branch January 4, 2021 12:46
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@jmroot @adorilson
bpo-42692: fix __builtin_available check on older compilers (pythonGH…
56aff58 
…-23873)

A compiler that doesn't define `__has_builtin` will error out when it is
used on the same line as the check for it.

Automerge-Triggered-By: GH:ronaldoussoren
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

Assignees

No one assigned

Labels

OS-mac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmroot @miss-islington @bedevere-bot @ronaldoussoren @the-knights-who-say-ni @ned-deily