Skip to content

[doc] Link to issue regarding logging.disable level param default value#23726

Merged
miss-islington merged 1 commit into
python:masterfrom
andresdelfino:link_to_critical_issue
Dec 9, 2020
Merged

[doc] Link to issue regarding logging.disable level param default value#23726
miss-islington merged 1 commit into
python:masterfrom
andresdelfino:link_to_critical_issue

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Dec 9, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:orsenthil

@andresdelfino
andresdelfino requested a review from vsajip as a code owner December 9, 2020 22:46
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 9, 2020
@miss-islington
miss-islington merged commit 2a35137 into python:master Dec 9, 2020
@miss-islington

miss-islington commented Dec 9, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@andresdelfino
andresdelfino deleted the link_to_critical_issue branch December 9, 2020 23:42
@miss-islington

miss-islington commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@orsenthil

orsenthil commented Dec 10, 2020

Copy link
Copy Markdown
Member

Looks like miss-islington could not backport this.
@andresdelfino , if you don't mind backporting your patch to 3.9 and 3.8 docs, please contribute them. I will review/merge it.

@andresdelfino

andresdelfino commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

Looks like miss-islington could not backport this.
@andresdelfino , if you don't mind backporting your patch to 3.9 and 3.8 docs, please contribute them. I will review/merge it.

Yes, of course!

@miss-islington

miss-islington commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@andresdelfino andresdelfino mentioned this pull request Dec 10, 2020
Merged
@bedevere-bot

bedevere-bot commented Dec 10, 2020

Copy link
Copy Markdown

GH-23731 is a backport of this pull request to the 3.8 branch.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 10, 2020
@andresdelfino
[3.8] [doc] Link to issue regarding logging.disable level param defau…
6039a9e 
…lt value (pythonGH-23726)

(cherry picked from commit 2a35137)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino mentioned this pull request Dec 10, 2020
Merged
@bedevere-bot

bedevere-bot commented Dec 10, 2020

Copy link
Copy Markdown

GH-23732 is a backport of this pull request to the 3.9 branch.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 10, 2020
@andresdelfino
[3.9] [doc] Link to issue regarding logging.disable level param defau…
5ad8c03 
…lt value (pythonGH-23726)

(cherry picked from commit 2a35137)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@miss-islington

miss-islington commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Sorry, @andresdelfino, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2a35137328154aa2513649dcf0bbef02c998e27c 3.9

@miss-islington miss-islington self-assigned this Dec 13, 2020
@miss-islington

miss-islington commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Sorry, @andresdelfino, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2a35137328154aa2513649dcf0bbef02c998e27c 3.8

@miss-islington

miss-islington commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Sorry @andresdelfino, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2a35137328154aa2513649dcf0bbef02c998e27c 3.9

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
[doc] Link to issue regarding logging.disable level param default val…
8f10bcb 
…ue (pythonGH-23726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes
@vsajip vsajip Awaiting requested review from vsajip

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andresdelfino @miss-islington @orsenthil @bedevere-bot @the-knights-who-say-ni