Skip to content

bpo-31904: skip some tests of changing owner in _test_all_chown_common() on VxWorks #23716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 3 commits into from
Dec 15, 2020
Merged

bpo-31904: skip some tests of changing owner in _test_all_chown_common() on VxWorks #23716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e01139
Skip some tests in _test_all_chown_common() on VxWorks
pxinwr Dec 9, 2020
d5e2e47
test chown for super user on VxWorks
pxinwr Dec 11, 2020
212b673
Update Lib/test/test_posix.py
pxinwr Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Lib/test/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,11 +724,20 @@ def check_stat(uid, gid):
chown_func(first_param, uid, -1)
check_stat(uid, gid)

if uid == 0:
if sys.platform == "vxworks":
# On VxWorks, root user id is 1 and 0 means no login user:
# both are super users.
is_root = (uid in (0, 1))
else:
is_root = (uid == 0)
if is_root:
# Try an amusingly large uid/gid to make sure we handle
# large unsigned values. (chown lets you use any
# uid/gid you like, even if they aren't defined.)
#
# On VxWorks uid_t is defined as unsigned short. A big
# value greater than 65535 will result in underflow error.
#
# This problem keeps coming up:
# http://bugs.python.org/issue1747858
# http://bugs.python.org/issue4591
Expand All @@ -738,7 +747,7 @@ def check_stat(uid, gid):
# This part of the test only runs when run as root.
# Only scary people run their tests as root.

big_value = 2**31
big_value = (2**31 if sys.platform != "vxworks" else 2**15)
chown_func(first_param, big_value, big_value)
check_stat(big_value, big_value)
chown_func(first_param, -1, -1)
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2020-12-09-15-23-28.bpo-31904.ghj38d.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Skip some tests in _test_all_chown_common() on VxWorks.