Skip to content

bpo-42423: Accept single base class in PyType_FromModuleAndSpec()#23441

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
serhiy-storchaka:PyType_FromModuleAndSpec-single-base-class
Nov 22, 2020
Merged

bpo-42423: Accept single base class in PyType_FromModuleAndSpec()#23441
serhiy-storchaka merged 3 commits into
python:masterfrom
serhiy-storchaka:PyType_FromModuleAndSpec-single-base-class

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 21, 2020

Copy link
Copy Markdown
Member

Comment thread Modules/_hashopenssl.c Outdated
Comment thread Objects/structseq.c Outdated
@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Comment thread Doc/whatsnew/3.10.rst Outdated
Comment on lines +519 to +520
* The :c:func:`PyType_FromModuleAndSpec` and :c:func:`PyType_FromModuleAndSpec`
functions now accept ``NULL`` as the ``tp_doc`` slot.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the other entry.

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot
bedevere-bot requested a review from tiran November 21, 2020 12:54
@serhiy-storchaka
serhiy-storchaka merged commit 686c203 into python:master Nov 22, 2020
@serhiy-storchaka
serhiy-storchaka deleted the PyType_FromModuleAndSpec-single-base-class branch November 22, 2020 11:25
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL7 3.x has failed when building commit 686c203.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/539/builds/367) and take a look at the build logs.
  4. Check if the failure is related to this commit (686c203) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/539/builds/367

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

410 tests OK.

10 slowest tests:

  • test_concurrent_futures: 4 min 1 sec
  • test_unparse: 3 min 44 sec
  • test_tokenize: 3 min 17 sec
  • test_capi: 3 min 1 sec
  • test_asyncio: 2 min 47 sec
  • test_peg_generator: 2 min 41 sec
  • test_lib2to3: 2 min 29 sec
  • test_multiprocessing_spawn: 2 min 28 sec
  • test_multiprocessing_forkserver: 1 min 32 sec
  • test_unicodedata: 1 min 25 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 7 min 6 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

@encukou

encukou commented Nov 24, 2020

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants