bpo-29076: Add fish support to macOS installer by erlend-aasland · Pull Request #23302 · python/cpython

erlend-aasland · 2020-11-15T16:50:58Z

https://bugs.python.org/issue29076

Automerge-Triggered-By: GH:ronaldoussoren

erlend-aasland · 2020-11-15T16:51:30Z

@ronaldoussoren PR, as promised on bpo.

ronaldoussoren

LGTM

github-actions · 2020-12-16T00:27:00Z

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

miss-islington · 2020-12-25T11:01:32Z

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

miss-islington · 2020-12-25T11:01:34Z

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-bot · 2020-12-25T11:01:48Z

GH-23937 is a backport of this pull request to the 3.9 branch.

bedevere-bot · 2020-12-25T11:02:00Z

GH-23938 is a backport of this pull request to the 3.8 branch.

(cherry picked from commit 7f162e8) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot · 2021-01-28T15:15:23Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.9 has failed when building commit e9c6c26.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/151/builds/281) and take a look at the build logs.
Check if the failure is related to this commit (e9c6c26) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/151/builds/281

Failed tests:

test_gdb
test_subprocess
test_venv

Failed subtests:

test_specific_shell - test.test_subprocess.POSIXProcessTestCase
test_deactivate_with_strict_bash_opts - test.test_venv.BasicTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

403 tests OK.

10 slowest tests:

test_concurrent_futures: 4 min 18 sec
test_multiprocessing_spawn: 3 min 14 sec
test_tokenize: 3 min 8 sec
test_multiprocessing_forkserver: 2 min 47 sec
test_subprocess: 2 min 39 sec
test_lib2to3: 2 min 5 sec
test_multiprocessing_fork: 1 min 55 sec
test_asyncio: 1 min 50 sec
test_unparse: 1 min 49 sec
test_capi: 1 min 43 sec

3 tests failed:
test_gdb test_subprocess test_venv

19 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

3 re-run tests:
test_gdb test_subprocess test_venv

Total duration: 17 min 29 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_subprocess.py", line 2217, in test_specific_shell
    self.assertEqual(p.stdout.read().strip(), bytes(sh, 'ascii'))
AssertionError: b'' != b'/usr/local/bin/bash'


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 391, in test_deactivate_with_strict_bash_opts
    out, err = check_output([bash, test_script])
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 44, in check_output
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['/usr/local/bin/bash', '/var/tmp/tmpcv235iog/test_strict.sh']' returned non-zero exit status 1.


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 391, in test_deactivate_with_strict_bash_opts
    out, err = check_output([bash, test_script])
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 44, in check_output
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['/usr/local/bin/bash', '/var/tmp/tmpbtdm7lfd/test_strict.sh']' returned non-zero exit status 1.


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/libregrtest/runtest.py", line 270, in _runtest_inner
    refleak = _runtest_inner2(ns, test_name)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/libregrtest/runtest.py", line 221, in _runtest_inner2
    the_module = importlib.import_module(abstest)
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 790, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_gdb.py", line 48, in <module>
    gdb_version, gdb_major_version, gdb_minor_version = get_gdb_version()
  File "/usr/home/buildbot/python/3.9.koobs-freebsd-564d/build/Lib/test/test_gdb.py", line 29, in get_gdb_version
    raise Exception(f"Command {' '.join(cmd)!r} failed "
Exception: Command 'gdb -nx --version' failed with exit code 1: stdout='' stderr='ld-elf.so.1: Shared object "libncursesw.so.6" not found, required by "gdb"\n'

bedevere-bot · 2021-01-28T15:55:51Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.8 has failed when building commit 81b23a9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/555/builds/195) and take a look at the build logs.
Check if the failure is related to this commit (81b23a9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/555/builds/195

Failed tests:

test_gdb
test_subprocess
test_venv

Failed subtests:

test_specific_shell - test.test_subprocess.POSIXProcessTestCase
test_deactivate_with_strict_bash_opts - test.test_venv.BasicTest
test_already_running - test.test__xxsubinterpreters.RunStringTests
test_subinterpreter - test.test__xxsubinterpreters.IsRunningTests
test_still_running - test.test__xxsubinterpreters.DestroyTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

401 tests OK.

10 slowest tests:

test_multiprocessing_spawn: 3 min 48 sec
test_concurrent_futures: 3 min 44 sec
test_tokenize: 3 min 9 sec
test_multiprocessing_forkserver: 2 min 48 sec
test_multiprocessing_fork: 2 min 38 sec
test_tools: 2 min 22 sec
test_subprocess: 2 min 18 sec
test_lib2to3: 1 min 50 sec
test_asyncio: 1 min 36 sec
test_io: 1 min 26 sec

3 tests failed:
test_gdb test_subprocess test_venv

19 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

5 re-run tests:
test__xxsubinterpreters test_gdb test_subprocess test_threading
test_venv

Total duration: 38 min 1 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 358, in test_deactivate_with_strict_bash_opts
    out, err = check_output([bash, test_script])
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 44, in check_output
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['/usr/local/bin/bash', '/var/tmp/tmpvd34m9cm/test_strict.sh']' returned non-zero exit status 1.


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test__xxsubinterpreters.py", line 51, in run
    interpreters.run_string(interp, dedent(f"""
RuntimeError: interpreter already running


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test__xxsubinterpreters.py", line 495, in test_subinterpreter
    self.assertTrue(interpreters.is_running(interp))
AssertionError: False is not true


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/libregrtest/runtest.py", line 270, in _runtest_inner
    refleak = _runtest_inner2(ns, test_name)
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/libregrtest/runtest.py", line 221, in _runtest_inner2
    the_module = importlib.import_module(abstest)
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test_gdb.py", line 48, in <module>
    gdb_version, gdb_major_version, gdb_minor_version = get_gdb_version()
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test_gdb.py", line 29, in get_gdb_version
    raise Exception(f"Command {' '.join(cmd)!r} failed "
Exception: Command 'gdb -nx --version' failed with exit code 1: stdout='' stderr='ld-elf.so.1: Shared object "libncursesw.so.6" not found, required by "gdb"\n'


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test__xxsubinterpreters.py", line 860, in test_already_running
    interpreters.run_string(self.id, 'print("spam")')
AssertionError: RuntimeError not raised


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test_subprocess.py", line 2000, in test_specific_shell
    self.assertEqual(p.stdout.read().strip(), bytes(sh, 'ascii'))
AssertionError: b'' != b'/usr/local/bin/bash'


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test__xxsubinterpreters.py", line 765, in test_still_running
    self.assertTrue(interpreters.is_running(interp),
AssertionError: False is not true : Interp 39 should be running before destruction.


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 358, in test_deactivate_with_strict_bash_opts
    out, err = check_output([bash, test_script])
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-564d/build/Lib/test/test_venv.py", line 44, in check_output
    raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '['/usr/local/bin/bash', '/var/tmp/tmpyz1azu7q/test_strict.sh']' returned non-zero exit status 1.

bpo-29076: Add fish support to macOS build

ac66eb9

erlend-aasland requested a review from a team as a code owner November 15, 2020 16:50

the-knights-who-say-ni added the CLA signed label Nov 15, 2020

bedevere-bot added the awaiting review label Nov 15, 2020

erlend-aasland changed the title ~~bpo-29076: Add fish support to macOS build~~ bpo-29076: Add fish support to macOS installer Nov 15, 2020

ronaldoussoren approved these changes Nov 15, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Nov 15, 2020

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020

ned-deily self-assigned this Dec 16, 2020

ned-deily removed the stale Stale PR or inactive for long period of time. label Dec 16, 2020

ronaldoussoren added needs backport to 3.8 OS-mac labels Dec 25, 2020

miss-islington merged commit 7f162e8 into python:master Dec 25, 2020

bedevere-bot removed the awaiting merge label Dec 25, 2020

bedevere-bot removed needs backport to 3.9 labels Dec 25, 2020

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 25, 2020

bpo-29076: Add fish support to macOS installer (pythonGH-23302)

b3d8c14

(cherry picked from commit 7f162e8) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 25, 2020

bpo-29076: Add fish support to macOS installer (pythonGH-23302)

53707eb

(cherry picked from commit 7f162e8) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

erlend-aasland deleted the bpo-29076 branch December 25, 2020 12:20

ned-deily pushed a commit that referenced this pull request Jan 28, 2021

bpo-29076: Add fish support to macOS installer (GH-23302) (GH-23937)

e9c6c26

(cherry picked from commit 7f162e8) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

ned-deily pushed a commit that referenced this pull request Jan 28, 2021

bpo-29076: Add fish support to macOS installer (GH-23302) (GH-23938)

81b23a9

(cherry picked from commit 7f162e8) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021

bpo-29076: Add fish support to macOS installer (pythonGH-23302)

5f0dd9a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-29076: Add fish support to macOS installer#23302

bpo-29076: Add fish support to macOS installer#23302
miss-islington merged 1 commit into
python:masterfrom
erlend-aasland:bpo-29076

erlend-aasland commented Nov 15, 2020 •

edited by miss-islington

Loading

Uh oh!

erlend-aasland commented Nov 15, 2020

Uh oh!

ronaldoussoren left a comment

Uh oh!

github-actions Bot commented Dec 16, 2020

Uh oh!

miss-islington commented Dec 25, 2020

Uh oh!

miss-islington commented Dec 25, 2020

Uh oh!

bedevere-bot commented Dec 25, 2020

Uh oh!

bedevere-bot commented Dec 25, 2020

Uh oh!

bedevere-bot commented Jan 28, 2021

Uh oh!

bedevere-bot commented Jan 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

erlend-aasland commented Nov 15, 2020 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Nov 15, 2020

Uh oh!

ronaldoussoren left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 16, 2020

Uh oh!

miss-islington commented Dec 25, 2020

Uh oh!

miss-islington commented Dec 25, 2020

Uh oh!

bedevere-bot commented Dec 25, 2020

Uh oh!

bedevere-bot commented Dec 25, 2020

Uh oh!

bedevere-bot commented Jan 28, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Jan 28, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented Nov 15, 2020 •

edited by miss-islington

Loading