Skip to content

Conversation

@basak
Copy link
Contributor

@basak basak commented Nov 14, 2020

Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are not
needed.

Automerge-Triggered-By: GH:JulienPalard

Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are *not*
needed.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@basak

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@basak
Copy link
Contributor Author

basak commented Nov 14, 2020

CLI signed, and I think you probably want "skip issue" and "skip news" for this.

@JulienPalard
Copy link
Member

Hi @basak! Good catch and thanks for the PR!

@miss-islington
Copy link
Contributor

@basak: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 9d09e17 into python:master Nov 25, 2020
@miss-islington
Copy link
Contributor

Thanks @basak for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2020
Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are *not*
needed.

Automerge-Triggered-By: GH:JulienPalard
(cherry picked from commit 9d09e17)

Co-authored-by: basak <robie@justgohome.co.uk>
@bedevere-bot
Copy link

GH-23512 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

Thanks @basak for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Looks like a "not" was inadvertently omitted in commit e6a7ea4.
Classmethods are useful when data stored in specific instances are *not*
needed.

Automerge-Triggered-By: GH:JulienPalard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants