bpo-42332: Add weakref slot to types.GenericAlias#23250
Conversation
|
I created the issue, and I have no experience setting those fields. It'd be great to get it in the next 3.9 release though. |
|
Also, thank you for implementing this! |
|
You're welcome! Personally, I'd like to see this on the next 3.9 release too, I'll just see what the core devs decide. Btw, I have a feeling that arguments on whether to backport or not should go onto the bpo thread, so that it's easier for others to follow. |
jstasiak
left a comment
There was a problem hiding this comment.
Two small comments but looks good to me otherwise.
|
@Fidget-Spinner: Status check is done, and it's a failure ❌ . |
|
c1 : fatal error C1083: Cannot open source file: 'D:\a\1\b\externals\sqlite-3.33.0.0\sqlite3.c': No such file or directory [D:\a\1\s\PCbuild\sqlite3.vcxproj]
3 Warning(s)
1 Error(s)
Time Elapsed 00:03:34.57
##[error]Cmd.exe exited with code '1'.
EDIT: Traceback (most recent call last):
File "D:\a\1\s\PCbuild\\get_external.py", line 60, in <module>
main()
File "D:\a\1\s\PCbuild\\get_external.py", line 48, in main
zip_path = fetch_zip(
File "D:\a\1\s\PCbuild\\get_external.py", line 17, in fetch_zip
filename, headers = urlretrieve(
File "C:\hostedtoolcache\windows\Python\3.8.6\x64\lib\urllib\request.py", line 247, in urlretrieve
with contextlib.closing(urlopen(url, data)) as fp:
File "C:\hostedtoolcache\windows\Python\3.8.6\x64\lib\urllib\request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "C:\hostedtoolcache\windows\Python\3.8.6\x64\lib\urllib\request.py", line 531, in open
response = meth(req, response)
File "C:\hostedtoolcache\windows\Python\3.8.6\x64\lib\urllib\request.py", line 640, in http_response
response = self.parent.error(
File "C:\hostedtoolcache\windows\Python\3.8.6\x64\lib\urllib\request.py", line 569, in error
return self._call_chain(*args)
File "C:\hostedtoolcache\windows\Python\3.8.6\x64\lib\urllib\request.py", line 502, in _call_chain
result = func(*args)
File "C:\hostedtoolcache\windows\Python\3.8.6\x64\lib\urllib\request.py", line 649, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 504: Gateway Time-out
|
|
Sorry @gvanrossum, is it possible for you to trigger a re-run of the Azure Pipelines Github Action? Or do I have to push an empty commit? |
|
I don’t know how to trigger just that, but I will close and then reopen. |
|
You may also try rebasing, in case it’s fixed in main. |
|
@Fidget-Spinner: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@Fidget-Spinner: Status check is done, and it's a failure ❌ . |
|
Hopefully miss islington will eventually get it. |
|
@Fidget-Spinner: Status check is done, and it's a success ✅ . |
|
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @Fidget-Spinner, I could not cleanly backport this to |
|
GH-23309 is a backport of this pull request to the 3.9 branch. |
Automerge-Triggered-By: GH:gvanrossum
https://bugs.python.org/issue42332
Automerge-Triggered-By: GH:gvanrossum