bpo-42233: Add union type expression support for GenericAlias and fix de-duplicating of GenericAlias#23077
Merged
Merged
Conversation
gvanrossum
reviewed
Nov 1, 2020
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
I hope @serhiy-storchaka can finish this review?
gvanrossum
reviewed
Nov 7, 2020
gvanrossum
reviewed
Nov 8, 2020
gvanrossum
reviewed
Nov 9, 2020
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
No worries. And I'm sorry, but it's not quite over (though we're very close!).
Also, can you please add a test for the failure path (like what I showed previously)?
Member
|
Thanks! |
Contributor
|
Thanks @Fidget-Spinner for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Contributor
|
Sorry, @Fidget-Spinner and @gvanrossum, I could not cleanly backport this to |
Member
Author
|
Thanks for being so patient and taking the time for multiple rounds of reviews. I learnt a lot from this. Hopefully, whatever I write in the future won't require this many edits again BTW, I don't think a backport is required - union expressions are 3.10 only |
Member
|
D'oh. Adding the backport label is a reflex for me. :-) Can we close the issue? |
Member
Author
Yup! |
|
Member
|
My guess is that the asyncio tests are flaky, so not to worry unless Victor tracks us down. :-) |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
… de-duplicating of GenericAlias (pythonGH-23077)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42233