bpo-42232: mmap module add Darwin specific madvise options.#23076
Merged
miss-islington merged 3 commits intoNov 21, 2020
Conversation
devnexen
changed the title
jstasiak
approved these changes
Nov 2, 2020
jstasiak
left a comment
jstasiak
left a comment
Contributor
There was a problem hiding this comment.
Works for me on Mac OS 10.14.6:
Python 3.10.0a1+ (remotes/origin/pr/23076:b06ca8b38c28, Nov 2 2020, 20:52:28)
[Clang 10.0.1 (clang-1001.0.46.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import mmap
>>> mmap.MADV_FREE_REUSABLE
7
>>> mmap.MADV_FREE_REUSE
8
What worries me a little is I couldn't find any documentation on those, but I guess it is what it s. One change I'd make is add these to the MADV_* Constants section in the docs since others are already listed.
Contributor
Author
It does not appear in the man page (I stumbled across :-)) but the system reports more faithfully the memory usage than MADV_FREE could. |
Contributor
|
Sorry, I can't merge this PR. Reason: |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue42232
Automerge-Triggered-By: GH:ronaldoussoren