Skip to content

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Oct 30, 2020

@vstinner
Copy link
Member

Tests / Windows (x64) (pull_request) Failing after 1m — Windows (x64)

Network issue. I re-run the job.

https: //github.com/python/core-workflow/issues/380
Signed-off-by: Filipe Laíns <lains@archlinux.org>
exit 1
fi
- name: Check exported libpython symbols
run: make smelly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to suggest to add a message explaining that the check ensures that libpython only exports starting with Py and _Py. But instead, I wrote PR #23423 to enhance the script directly ;-)

@vstinner vstinner merged commit d20b7ed into python:master Nov 20, 2020
@vstinner
Copy link
Member

Merged, thanks!

@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @FFY00 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-23493 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2020
…ythonGH-23042)

See https: //github.com/python/core-workflow/issues/380

Signed-off-by: Filipe Laíns <lains@archlinux.org>
(cherry picked from commit d20b7ed)

Co-authored-by: Filipe Laíns <lains@archlinux.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2020
…ythonGH-23042)

See https: //github.com/python/core-workflow/issues/380

Signed-off-by: Filipe Laíns <lains@archlinux.org>
(cherry picked from commit d20b7ed)

Co-authored-by: Filipe Laíns <lains@archlinux.org>
@bedevere-bot
Copy link

GH-23494 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 24, 2020
…H-23042)

See https: //github.com/python/core-workflow/issues/380

Signed-off-by: Filipe Laíns <lains@archlinux.org>
(cherry picked from commit d20b7ed)

Co-authored-by: Filipe Laíns <lains@archlinux.org>
miss-islington added a commit that referenced this pull request Nov 24, 2020
…H-23042)

See https: //github.com/python/core-workflow/issues/380

Signed-off-by: Filipe Laíns <lains@archlinux.org>
(cherry picked from commit d20b7ed)

Co-authored-by: Filipe Laíns <lains@archlinux.org>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants