bpo-42010: Prevent generic types from being indexed#22667
Closed
Fidget-Spinner wants to merge 3 commits into
Closed
bpo-42010: Prevent generic types from being indexed#22667Fidget-Spinner wants to merge 3 commits into
Fidget-Spinner wants to merge 3 commits into
Conversation
Fidget-Spinner
changed the title
Fidget-Spinner
marked this pull request as draft
October 12, 2020 09:59
tirkarthi
reviewed
Oct 12, 2020
Member
Author
|
Due to the fact that integer variadics are in the works, and I've yet to find empirical evidence that people are getting confused, I'm closing this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested working on WIndows 10. I ran the whole test suite and other than some locale tests failing (which are expected and have been reported before), everything seems fine.
This probably needs a backport to 3.9. Though I'm unsure if an issue is required since it doesn't seem like a big change, rather it keeps consistency with previous python versions.
https://bugs.python.org/issue42010