bpo-30523: Add --list-cases unittest#2243
Merged
Merged
Conversation
mlouielu
force-pushed
the
add_list_cases_unittest
branch
from
June 16, 2017 10:38
c79e9ea to
10dd852
Compare
vstinner
requested changes
Jun 16, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Please remove also my comment "# Any code which causes a crash" from test_matchfile(). This comment is a copy/paste mistake from test_crashed().
| pass | ||
| def test_method2(self): | ||
| pass | ||
| def test_method3(self): |
Member
There was a problem hiding this comment.
2 methods are enough. Remove test_method3 & test_method4 please.
| '%s.Tests.test_method3' % testname, | ||
| '%s.Tests.test_method4' % testname] | ||
| output = self.run_tests('--list-cases', testname) | ||
| self.assertEqual(output.rstrip().splitlines(), all_methods) |
|
|
||
| def test_list_cases(self): | ||
| # test --list-cases | ||
| # TODO: Add doctest testcase |
Member
There was a problem hiding this comment.
please remove the TODO, I would prefer to open a new bpo for that.
vstinner
approved these changes
Jun 16, 2017
Member
|
Thanks @mlouielu! I now feel more confortable with an unit test ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.