Skip to content

(merge after 3.8.6 final) [3.8] bpo-41855: Fix duplicate results in FastPath.zip_children()#22403

Closed
jaraco wants to merge 2 commits into
3.8from
bpo-41855-backport-fix
Closed

(merge after 3.8.6 final) [3.8] bpo-41855: Fix duplicate results in FastPath.zip_children()#22403
jaraco wants to merge 2 commits into
3.8from
bpo-41855-backport-fix

Conversation

@jaraco

@jaraco jaraco commented Sep 24, 2020

Copy link
Copy Markdown
Member

@jaraco

jaraco commented Sep 24, 2020

Copy link
Copy Markdown
Member Author

Sorry for the noise. I did not intentionally create all of those review requests. I simply used the hub pull-request -c command :(.

@jaraco jaraco changed the title Clean up compatibility code in importlib fixtures. bpo-41855: Clean up compatibility code in importlib fixtures. Sep 24, 2020
@jaraco jaraco changed the title bpo-41855: Clean up compatibility code in importlib fixtures. [3.8] bpo-41855: Clean up compatibility code in importlib fixtures. Sep 24, 2020
@gvanrossum gvanrossum closed this Sep 24, 2020
@jaraco jaraco reopened this Sep 24, 2020
@jaraco jaraco changed the title [3.8] bpo-41855: Clean up compatibility code in importlib fixtures. (merge after 3.8.6 final) [3.8] bpo-41855: Fix duplicate results in FastPath.zip_children() Sep 24, 2020
@jaraco

jaraco commented Sep 24, 2020

Copy link
Copy Markdown
Member Author

Not sure why the PR was closed by Guido. I do want to get a review on this PR and plan to merge it ASAP once the branch is unfrozen.

@jaraco
jaraco requested a review from warsaw September 24, 2020 22:03
@ned-deily

Copy link
Copy Markdown
Member

I think Guido was suggesting you create a new clean PR from an uptodate 3.8 branch to avoid all the unnecessary notices etc.

@jaraco jaraco closed this Sep 24, 2020
@jaraco

jaraco commented Sep 24, 2020

Copy link
Copy Markdown
Member Author

I can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants