(merge after 3.8.6 final) [3.8] bpo-41855: Fix duplicate results in FastPath.zip_children()#22403
Closed
jaraco wants to merge 2 commits into
Closed
(merge after 3.8.6 final) [3.8] bpo-41855: Fix duplicate results in FastPath.zip_children()#22403jaraco wants to merge 2 commits into
jaraco wants to merge 2 commits into
Conversation
jaraco
requested review from
a team,
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
ethanfurman,
gpshead,
gvanrossum,
ilevkivskyi,
lysnikolaou,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
terryjreedy,
tiran,
vsajip and
warsaw
as code owners
September 24, 2020 20:41
jaraco
removed request for
1st1,
abalkin,
asvetlov,
encukou,
ericsnowcurrently,
ericvsmith,
ethanfurman,
gvanrossum,
ilevkivskyi,
lysnikolaou,
methane,
ncoghlan,
pablogsal,
pganssle,
rhettinger,
terryjreedy,
tiran and
warsaw
September 24, 2020 20:42
Member
Author
|
Sorry for the noise. I did not intentionally create all of those review requests. I simply used the |
Member
Author
|
Not sure why the PR was closed by Guido. I do want to get a review on this PR and plan to merge it ASAP once the branch is unfrozen. |
Member
|
I think Guido was suggesting you create a new clean PR from an uptodate 3.8 branch to avoid all the unnecessary notices etc. |
Member
Author
|
I can do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41855