Skip to content

bpo-41840: Report module-level globals as both local and global in the symtable module#22391

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-41840
Oct 3, 2020
Merged

bpo-41840: Report module-level globals as both local and global in the symtable module#22391
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo-41840

Conversation

@pablogsal

@pablogsal pablogsal commented Sep 23, 2020

Copy link
Copy Markdown
Member

@pablogsal pablogsal changed the title Report module-level globals as both local and global in the symtable module bpo-41840: Report module-level globals as both local and global in the symtable module Sep 23, 2020
@pablogsal
pablogsal force-pushed the bpo-41840 branch 2 times, most recently from dfca0a8 to dc8fb13 Compare September 23, 2020 22:22
Comment thread Lib/symtable.py Outdated
Comment thread Lib/symtable.py Outdated
@pablogsal
pablogsal merged commit fb0a465 into python:master Oct 3, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@pablogsal
pablogsal deleted the bpo-41840 branch October 3, 2020 19:46
@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fb0a4651f1be4ad936f8277478f73f262d8eeb72 3.9

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker fb0a4651f1be4ad936f8277478f73f262d8eeb72 3.8

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 3, 2020
… in the symtable module (pythonGH-22391).

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-22528 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 3, 2020
… in the symtable module (pythonGH-22391).

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Oct 3, 2020
… in the symtable module (GH-22391). (GH-22528)

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Oct 3, 2020
… in the symtable module (GH-22391). (GH-22529)

(cherry picked from commit fb0a465)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants