bpo-41624: fix documentation of typing.Coroutine#21952
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
tirkarthi
left a comment
tirkarthi
left a comment
There was a problem hiding this comment.
LGTM. Thanks. News entry is not needed. I will add skip-news label.
|
Thanks @Elaphurus for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @Elaphurus for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @Elaphurus and @ambv, I could not cleanly backport this to |
|
Sorry @Elaphurus and @ambv, I had trouble checking out the |
(cherry picked from commit 8c58d2a) Co-authored-by: MingZhe Hu <humingzhework@163.com>
|
GH-21982 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 8c58d2a) Co-authored-by: MingZhe Hu <humingzhework@163.com>
|
GH-21983 is a backport of this pull request to the 3.8 branch. |
6 participants
The documentation [1] for Coroutine in typing library writes:
class typing.Coroutine(Awaitable[V_co], Generic[T_co T_contra, V_co])
which should be:
class typing.Coroutine(Awaitable[V_co], Generic[T_co, T_contra, V_co])
a comma is missed between the first type variable T_co and the second one T_contr.
[1] https://docs.python.org/3/library/typing.html#typing.Coroutine
https://bugs.python.org/issue41624