Skip to content

bpo-30662: fixed OrderedDict.__init__ docstring re PEP 468 #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhettinger merged 5 commits into from
Sep 5, 2017
Merged

bpo-30662: fixed OrderedDict.__init__ docstring re PEP 468 #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5bded52
fixed OrderedDict.__init__ docstring re PEP 468
jonathaneunice Jun 14, 2017
f4669d7
tightened comment and mirrored to C impl
jonathaneunice Jun 14, 2017
a8aa969
added space after period per marco-buttu
jonathaneunice Jun 14, 2017
e92589f
preserved substituted for stable
jonathaneunice Jun 14, 2017
b045fc7
drop references to Python 3.6 and PEP 468
jonathaneunice Jun 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Lib/collections/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,7 @@ class OrderedDict(dict):

def __init__(*args, **kwds):
'''Initialize an ordered dictionary. The signature is the same as
regular dictionaries, but keyword arguments are not recommended because
their insertion order is arbitrary.

regular dictionaries. Keyword argument order is preserved.
'''
if not args:
raise TypeError("descriptor '__init__' of 'OrderedDict' object "
Expand Down
3 changes: 1 addition & 2 deletions Objects/odictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,8 +882,7 @@ odict_eq(PyObject *a, PyObject *b)

PyDoc_STRVAR(odict_init__doc__,
"Initialize an ordered dictionary. The signature is the same as\n\
regular dictionaries, but keyword arguments are not recommended because\n\
their insertion order is arbitrary.\n\
regular dictionaries. Keyword argument order is preserved.\n\
\n\
");

Expand Down