Skip to content

bpo-41462: add os.set_blocking() support for VxWorks RTOS #21713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 4 commits into from
Dec 7, 2020
Merged

bpo-41462: add os.set_blocking() support for VxWorks RTOS #21713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a4082e
Fix _Py_set_blocking() for VxWorks RTOS
pxinwr Jul 31, 2020
521dbb8
add NEWS
pxinwr Aug 3, 2020
43cbea8
Merge remote-tracking branch 'upstream/master' into fix-issue-31904-f…
pxinwr Sep 21, 2020
157170a
add comments for VxWorks fix
pxinwr Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-08-03-17-54-32.bpo-41462.ek38d_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add :func:`os.set_blocking()` support for VxWorks RTOS.
4 changes: 3 additions & 1 deletion Python/fileutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2007,7 +2007,9 @@ _Py_get_blocking(int fd)
int
_Py_set_blocking(int fd, int blocking)
{
#if defined(HAVE_SYS_IOCTL_H) && defined(FIONBIO)
/* bpo-41462: On VxWorks, ioctl(FIONBIO) only works on sockets.
Use fcntl() instead. */
#if defined(HAVE_SYS_IOCTL_H) && defined(FIONBIO) && !defined(__VXWORKS__)

@vstinner vstinner Dec 7, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment, something like:

// bpo-41462: On VxWorks, ioctl(FIONBIO) only works on sockets: use fcntl() instead.

@pxinwr pxinwr Dec 7, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

int arg = !blocking;
if (ioctl(fd, FIONBIO, &arg) < 0)
goto error;
Expand Down