bpo-41435: Add sys._current_exceptions() function#21689
bpo-41435: Add sys._current_exceptions() function#21689serhiy-storchaka merged 1 commit intopython:masterfrom
Conversation
|
This is a fantastic idea. I don't have time to review it but hopefully @serhiy-storchaka can have a look. |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I am not sure that adding sys._current_exceptions() is the best solution.
Python/pystate.c
Outdated
There was a problem hiding this comment.
I have doubts that it would work fine without the GIL held because of: 1) auditing, 2) memory allocation.
There was a problem hiding this comment.
I copy/pasted the comment from sys._current_frames since they use the same mechanism. I can also factor the code and the comment elsewhere.
There was a problem hiding this comment.
You must not use the Python C API without holding the GIL: PyLong_FromUnsignedLong(), PyDict_SetItem(), etc. require to hold the GIL.
There was a problem hiding this comment.
Ok, we might want to update the comment for _current_frames then!
jd
force-pushed
the
sys-current-exceptions
branch
from
454c7c3 to
789d9b0
Compare
What would you propose? The use case is real. |
jd
force-pushed
the
sys-current-exceptions
branch
from
a2d698c to
e21084d
Compare
|
I do not know what the use case is exactly (I also do not know the use case of |
|
In my case, the use-case for both functions is to be able to do statistical profiling on programs and to learn which code paths are raising the most exceptions, which type of exceptions, etc. We do this currently in a hacky way with Cython and You can look at what Java and JFR do in this regard for example: https://stackoverflow.com/questions/60147519/how-to-profile-the-number-of-exceptions-generated-categorized-by-exception-clas |
|
@serhiy-storchaka Does that make a compelling argument? :) |
|
@vstinner any opinion on this? |
Lib/test/test_sys.py
Outdated
There was a problem hiding this comment.
I would prefer to use support.SHORT_TIMEOUT or even support.LONG_TIMEOUT if the timeout should not occur.
Python/pystate.c
Outdated
There was a problem hiding this comment.
I would prefer to ensure that the GIL is held. For example, call _Py_EnsureTstateNotNULL(tstate).
Python/pystate.c
Outdated
There was a problem hiding this comment.
You must not use the Python C API without holding the GIL: PyLong_FromUnsignedLong(), PyDict_SetItem(), etc. require to hold the GIL.
Python/sysmodule.c
Outdated
There was a problem hiding this comment.
-thread
=> thread's identifier
Python/pystate.c
Outdated
There was a problem hiding this comment.
A single thread can be associated to more than one Python thread state. It is possible that two interpreters run in the same thread, just not at the same time.
There was a problem hiding this comment.
This is also a limitation in _current_frames then, right?
I think it'd be fine in this case to mimic what _current_frames does in this regard.
Doc/library/sys.rst
Outdated
There was a problem hiding this comment.
It's not clear that threads with no exception are omitted in this dictionary.
jd
force-pushed
the
sys-current-exceptions
branch
from
e21084d to
62f48e2
Compare
jd
force-pushed
the
sys-current-exceptions
branch
2 times, most recently
from
eeed951 to
ae0e5d7
Compare
Python/pystate.c
Outdated
There was a problem hiding this comment.
These lines are too long. I propose to reduce indentation,
This adds a new function named sys._current_exceptions() which is equivalent ot sys._current_frames() except that it returns the exceptions currently handled by other threads. It is equivalent to calling sys.exc_info() for each running thread.
jd
force-pushed
the
sys-current-exceptions
branch
from
ae0e5d7 to
0726d17
Compare
|
Can someone press the button? |
This adds a new function named sys._current_exceptions() which is equivalent ot sys._current_frames() except that it returns the exceptions currently handled by other threads. It is equivalent to calling sys.exc_info() for each running thread.
6 participants
This adds a new function named sys._current_exceptions() which is equivalent ot
sys._current_frames() except that it returns the exceptions currently handled
by other threads. It is equivalent to calling sys.exc_info() for each running
thread.
https://bugs.python.org/issue41435