Skip to content

bpo-41332: Added missing connect_accepted_socket() to AbstractEventLoop#21533

Merged
asvetlov merged 3 commits into
python:masterfrom
agronholm:fix-issue-41332
Nov 26, 2020
Merged

bpo-41332: Added missing connect_accepted_socket() to AbstractEventLoop#21533
asvetlov merged 3 commits into
python:masterfrom
agronholm:fix-issue-41332

Conversation

@agronholm

@agronholm agronholm commented Jul 18, 2020

Copy link
Copy Markdown
Contributor

@aeros aeros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @agronholm.

+1, loop.connect_accepted_socket() seems to me like it should be included in AbstractEventLoop, as it's important to have for asyncio interoperability purposes when used in addition to other libraries for handling connections. I think you are correct @agronholm that it was simply missed, but I'll wait on approval from @1st1 and/or @asvetlov to confirm this prior to merging.

Also, this should include an update to the What's New document for 3.10, in the "Porting to Python 3.10 > Changes in the Python API" sub-section since it's adding a method to an ABC. See the 3.9 What's New for an example: https://docs.python.org/3.9/whatsnew/3.9.html#changes-in-the-python-api (since the section doesn't exist yet in the 3.10 version).

Comment thread Lib/asyncio/events.py Outdated
Co-authored-by: Kyle Stanley <aeros167@gmail.com>
@asvetlov

Copy link
Copy Markdown
Contributor

Let's merge as-is.

@asvetlov
asvetlov merged commit e3ef4d7 into python:master Nov 26, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…op (pythonGH-21533)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Co-authored-by: Kyle Stanley <aeros167@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants