Repository navigation
bpo-41202: Allow to provide custom exception handler to asyncio.run() - #21295
tomaszdrozdz wants to merge 2 commits into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
remilapeyre
left a comment
There was a problem hiding this comment.
Hi @tomaszdrozdz thanks for improving Python!
For this change to be accepted you will need to had some tests and update the documentation.
This will also require a NEWS entry, you can add one by using https://blurb-it.herokuapp.com/
|
Also, can you please update the title of the PR to "bpo-41202: Allow to provide custom exception handler to asyncio.run()"? No need to open a new PR for that, you can do so by using the "Edit" button at the top of the page near the PR title. |
1st1
left a comment
There was a problem hiding this comment.
Thanks for submitting a PR!
That said I'm -1 on the change as I explained in the issue. Blocking the PR for now.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for reply. |
|
Changes not wanted. Won't improve. |
bpo-41202: Allow to provide custom exception handler to asyncio.run()
https://bugs.python.org/issue41202