Skip to content

bpo-41202: Allow to provide custom exception handler to asyncio.run() - #21295

Closed
tomaszdrozdz wants to merge 2 commits into
python:masterfrom
tomaszdrozdz:implementing-issue-41202
Closed

tomaszdrozdz wants to merge 2 commits into
python:masterfrom
tomaszdrozdz:implementing-issue-41202

Conversation

@tomaszdrozdz

@tomaszdrozdz tomaszdrozdz commented Jul 3, 2020 •

Copy link
Copy Markdown

bpo-41202: Allow to provide custom exception handler to asyncio.run()

https://bugs.python.org/issue41202

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@tomaszdrozdz

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@remilapeyre remilapeyre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tomaszdrozdz thanks for improving Python!

For this change to be accepted you will need to had some tests and update the documentation.

This will also require a NEWS entry, you can add one by using https://blurb-it.herokuapp.com/

@remilapeyre

remilapeyre commented Jul 3, 2020 •

Copy link
Copy Markdown
Contributor

Also, can you please update the title of the PR to "bpo-41202: Allow to provide custom exception handler to asyncio.run()"?

No need to open a new PR for that, you can do so by using the "Edit" button at the top of the page near the PR title.

@tomaszdrozdz tomaszdrozdz changed the title Implementing issue-41202 bpo-41202: Allow to provide custom exception handler to asyncio.run() Jul 3, 2020

@1st1 1st1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR!

That said I'm -1 on the change as I explained in the issue. Blocking the PR for now.

@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tomaszdrozdz

Copy link
Copy Markdown
Author

Thanks for reply.
But I have some doubts.
I have put them in isue comment.

@tomaszdrozdz

Copy link
Copy Markdown
Author

Changes not wanted. Won't improve.

@tomaszdrozdz
tomaszdrozdz deleted the implementing-issue-41202 branch July 13, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants