Skip to content

bpo-41182 selector: use DefaultSelector based upon implementation#21257

Merged
miss-islington merged 1 commit into
python:masterfrom
Akasurde:selector_fix
Jul 23, 2020
Merged

bpo-41182 selector: use DefaultSelector based upon implementation#21257
miss-islington merged 1 commit into
python:masterfrom
Akasurde:selector_fix

Conversation

@Akasurde

@Akasurde Akasurde commented Jul 1, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.

Fixes: bpo-41182

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

https://bugs.python.org/issue41182

Automerge-Triggered-By: @gvanrossum

@the-knights-who-say-ni

This comment has been minimized.

Sign in to view
@Akasurde

Akasurde commented Jul 1, 2020

Copy link
Copy Markdown
Contributor Author

Working on fixing failing tests.

@Akasurde Akasurde mentioned this pull request Jul 13, 2020
Merged
tiran
tiran reviewed Jul 14, 2020
View reviewed changes
Comment thread Lib/selectors.py Outdated
gvanrossum
gvanrossum reviewed Jul 14, 2020
View reviewed changes
Comment thread Lib/selectors.py Outdated
aeros
aeros suggested changes Jul 15, 2020
View reviewed changes
Comment thread Lib/selectors.py Outdated
@bedevere-bot

bedevere-bot commented Jul 15, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

tiran
tiran reviewed Jul 16, 2020
View reviewed changes
Comment thread Lib/selectors.py Outdated
@Akasurde
selector: use DefaultSelector based upon implementation
6e3d288 
On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde

Akasurde commented Jul 16, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jul 16, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@aeros: please review the changes made to this pull request.

@bedevere-bot
bedevere-bot requested a review from aeros July 16, 2020 11:59
gvanrossum
gvanrossum approved these changes Jul 23, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I am going along with this.

@gvanrossum

gvanrossum commented Jul 23, 2020

Copy link
Copy Markdown
Member

PS. A meta-remark: please don’t force-push commits in response to code review. This makes changes harder to see for reviewers. We always squash commits when merging.

@Akasurde

Akasurde commented Jul 23, 2020

Copy link
Copy Markdown
Contributor Author

PS. A meta-remark: please don’t force-push commits in response to code review. This makes changes harder to see for reviewers. We always squash commits when merging.

I will take a note for the future, Thank you.

@miss-islington
miss-islington merged commit bcd4783 into python:master Jul 23, 2020
@gvanrossum

gvanrossum commented Jul 23, 2020

Copy link
Copy Markdown
Member

You're welcome. Do you need this backported to 3.9? (We'd need to petition the release manager given the next release is rc1.)

@Akasurde
Akasurde deleted the selector_fix branch July 23, 2020 05:05
@Akasurde

Akasurde commented Jul 23, 2020

Copy link
Copy Markdown
Contributor Author

@tiran @aeros @gvanrossum Thanks for the reviews. Yes, I would like to backport this to 3.9.

@aeros

aeros commented Jul 25, 2020

Copy link
Copy Markdown
Contributor

/cc @ambv

@miss-islington

miss-islington commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

Thanks @Akasurde for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2020
@Akasurde @miss-islington
bpo-41182 selector: use DefaultSelector based upon implementation (py…
71adb9d 
…thonGH-21257)

On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.

Fixes: [bpo-41182]()

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit bcd4783)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
@bedevere-bot

bedevere-bot commented Jul 26, 2020

Copy link
Copy Markdown

GH-21630 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jul 26, 2020
@miss-islington @Akasurde
bpo-41182 selector: use DefaultSelector based upon implementation (GH…
6e4975a 
…-21257)

On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.

Fixes: [bpo-41182]()

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit bcd4783)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@Akasurde @shihai1991
bpo-41182 selector: use DefaultSelector based upon implementation (py…
b1bac9c 
…thonGH-21257)

On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.

Fixes: [bpo-41182]()

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@Akasurde @shihai1991
bpo-41182 selector: use DefaultSelector based upon implementation (py…
e3cfbb3 
…thonGH-21257)

On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.

Fixes: [bpo-41182]()

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@Akasurde @xzy3-cdc
bpo-41182 selector: use DefaultSelector based upon implementation (py…
f461872 
…thonGH-21257)

On some platform such as VMware ESXi, DefaultSelector fails
to detect selector due to default value.
This fix adds a check and uses the correct selector depending upon
select implementation and actual call.

Fixes: [bpo-41182]()

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran left review comments
@gvanrossum gvanrossum gvanrossum approved these changes
+1 more reviewer
@aeros aeros aeros approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Akasurde @the-knights-who-say-ni @bedevere-bot @gvanrossum @aeros @miss-islington @tiran @ambv