bpo-41091: Remove recommendation in curses module documentation to initialize LC_ALL and encode strings#21159
Closed
manueljacob wants to merge 1 commit into
Closed
Conversation
…itialize LC_ALL and encode strings The recommendation to call `locale.setlocale(locale.LC_ALL, '')` is problematic as it initializes all locale categories to the user settings, which might be unintended and is not necessary for curses to work correctly. Initializing LC_CTYPE is sufficient for nl_langinfo() to return the correct encoding. Current versions of Python initialize LC_CTYPE at interpreter startup. Therefore calling locale.setlocale() should not be necessary at all. The curses module automatically encodes strings. Therefore the recommendation to manually encode strings is outdated.
akuchling
approved these changes
Oct 19, 2020
serhiy-storchaka
added
needs backport to 3.10
Member
|
This was removed in #91732. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recommendation to call
locale.setlocale(locale.LC_ALL, '')isproblematic as it initializes all locale categories to the user
settings, which might be unintended and is not necessary for curses to
work correctly. Initializing LC_CTYPE is sufficient for nl_langinfo() to
return the correct encoding. Current versions of Python initialize
LC_CTYPE at interpreter startup. Therefore calling locale.setlocale()
should not be necessary at all.
The curses module automatically encodes strings. Therefore the
recommendation to manually encode strings is outdated.
https://bugs.python.org/issue41091