Updated example for asyncio.gather ; the previous example did not fully showcase the interest of using gather#20581
Updated example for asyncio.gather ; the previous example did not fully showcase the interest of using gather#20581josephernest wants to merge 1 commit into
Conversation
…ly showcase the interest of using gather Here the example showcases "the result is an aggregate list of returned values"
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
|
||
| asyncio.run(main()) | ||
|
|
||
There was a problem hiding this comment.
You have some spurious white space here. That's why the Travis CI test failed.
|
Thanks for submitting the PR. I'll let @1st1 or @asvetlov review the content. Two process comments: (1) there is some spurious trailing white space on one line which needs to be removed (see comment I left on the file). (2) Unless a change specifically only applies to an older version, we ask that PRs be submitted against the master branch, rather than a release branch (ii.e. not 3.7). Core developers choosing to merge PRs to master will decide to which release branches, if any, the PR should be backported and we have tools to do that automatically. It would probably be easiest and safest if you would close this PR and submit a new one against master; trying to change the base branch of an existing PR on GitHub usually causes giant unwanted and unhelpful merges to be produced. |
|
@ned-deily Thanks for your answer. Could you give me a link to the file I should modify instead of the one I modified? Then I'll re-do a new pull request there. |
|
It's the same file, just in a different branch: |
|
@ned-deily I did a new PR here: #20604 |
4 participants
Updated example for
asyncio.gather; the previous example did not fully showcase the interest of using gather.Here the example showcases "the result is an aggregate list of returned values".