bpo-40707: Document that Popen.communicate sets the returncode attribute#20283
Merged
terryjreedy merged 3 commits intoJun 24, 2020
Merged
Conversation
remilapeyre
approved these changes
May 21, 2020
remilapeyre
left a comment
remilapeyre
left a comment
There was a problem hiding this comment.
Thanks for improving the docs @gareth-rees!
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
terryjreedy
requested changes
Jun 24, 2020
terryjreedy
approved these changes
Jun 24, 2020
Contributor
|
Thanks @gareth-rees for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2020
…ute (pythonGH-20283) (cherry picked from commit bf2e515) Co-authored-by: Gareth Rees <gdr@garethrees.org>
|
GH-21105 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2020
…ute (pythonGH-20283) (cherry picked from commit bf2e515) Co-authored-by: Gareth Rees <gdr@garethrees.org>
|
GH-21106 is a backport of this pull request to the 3.8 branch. |
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue 40707 by documenting that the
subprocess.Popen.communicate()method sets thereturncodeattribute.https://bugs.python.org/issue40707