Fix regression in error message introduced in bpo-29951.#2028
Merged
Conversation
vstinner
approved these changes
Jun 9, 2017
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
If you can, it would be nice to have one unit test for the error message. It seems like this case is not currently tested by test_call.
vstinner
requested changes
Jun 9, 2017
|
|
||
| def test_varargs3(self): | ||
| msg = r"from_bytes\(\) takes at most 2 positional arguments \(3 given\)" | ||
| self.assertRaisesRegex(TypeError, msg, int.from_bytes, b'a', 'little', False) |
Member
There was a problem hiding this comment.
This unit test is wrong: it doesn't catch the fixed bug. You need to add "^" at the start of the regex.
You may add "^" and "$" to all regex of this file ;-) (Maybe even write an helper function to create the regex?)
vstinner
approved these changes
Jun 9, 2017
Member
|
Thanks for the fix, but also for your overall work on error messages! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug is found by @Haypo.