Skip to content

bpo-40703: Let PyType_FromSpec() set "type.__module__" only if it is not set yet.#20273

Merged
scoder merged 2 commits into
python:masterfrom
scoder:bpo40703_type_module_name
Jun 10, 2020
Merged

bpo-40703: Let PyType_FromSpec() set "type.__module__" only if it is not set yet.#20273
scoder merged 2 commits into
python:masterfrom
scoder:bpo40703_type_module_name

Conversation

@scoder

@scoder scoder commented May 20, 2020

Copy link
Copy Markdown
Contributor

@encukou

encukou commented May 22, 2020

Copy link
Copy Markdown
Member

+1, this looks good to me. It wants a test, though. I'll try writing one when I get some free cycles.

@scoder

scoder commented Jun 10, 2020

Copy link
Copy Markdown
Contributor Author

I'll merge this for now to get it into Py3.9 finally, because it solves an annoying issue.
We can see about a test later on.

@scoder
scoder merged commit 24b8bad into python:master Jun 10, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @scoder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-20782 is a backport of this pull request to the 3.9 branch.

@scoder
scoder deleted the bpo40703_type_module_name branch June 10, 2020 16:09
scoder pushed a commit that referenced this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants