bpo-40669: Install PEG benchmarking dependencies in a venv#20183
bpo-40669: Install PEG benchmarking dependencies in a venv#20183miss-islington merged 2 commits intopython:masterfrom
Conversation
Create a `make venv` target, that creates a virtual environment and installs the dependency in that venv. `make time` and all the related targets are changed to use the virtual environment python.
|
Btw, while testing this PR I found that some of the benchmark scripts are broken (for example given that we are focusing on the Python parser now, maybe we could adapt those to use the |
The problem is that _peg_parser in its current state only parses and generates the external AST. It cannot compile to byte code and it cannot just parse the internal AST. Should we just add |
I see. In any case I suppose that comparing with the old parser will be something that we don't want to do anymore (and the old parser will be removed for the 3.10 series) so I wonder how many of these scripts should be deleted or just ported to use Could we do a review of the scripts we want to keep around and delete the rest? |
Added to my to-do list! Should we merge this as-is? |
Yeah, I think is still an improvement 👌 |
|
@lysnikolaou: Status check is done, and it's a success ✅ . |
…20183) Create a `make venv` target, that creates a virtual environment and installs the dependency in that venv. `make time` and all the related targets are changed to use the virtual environment python. Automerge-Triggered-By: @pablogsal
Create a
make venvtarget, that creates a virtual environmentand installs the dependency in that venv.
make timeand allthe related targets are changed to use the virtual environment
python.
https://bugs.python.org/issue40669
Automerge-Triggered-By: @pablogsal