Skip to content

bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message#19940

Merged
taleinat merged 2 commits into
python:masterfrom
tekknolagi:mb-charmap-formatting
Oct 17, 2020
Merged

bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message#19940
taleinat merged 2 commits into
python:masterfrom
tekknolagi:mb-charmap-formatting

Conversation

@tekknolagi

@tekknolagi tekknolagi commented May 5, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The formatter does not support %lx. Add previously failing tests.

https://bugs.python.org/issue42065

@tekknolagi
Fix incorrectly formatted _codecs.charmap_decode error message
81c891c 
The formatter does not support `%lx`. Add previously failing tests.
@tekknolagi

tekknolagi commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

I imagine this is minor enough that news & issue are not required. If this is not the case, happy to make one or both.

@csabella

csabella commented May 29, 2020

Copy link
Copy Markdown
Contributor

@tekknolagi, thank you for the pull request. You'd probably get more visibility on this with an issue on the bug tracker. It's easy for pull requests to be missed without a corresponding issue.

@tekknolagi

tekknolagi commented May 29, 2020

Copy link
Copy Markdown
Contributor Author

Is it mergeable as-is or should I make an issue?

@csabella

csabella commented May 31, 2020

Copy link
Copy Markdown
Contributor

Please make an issue.

@taleinat

taleinat commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

Indeed, as a bugfix, this needs an issue and a NEWS entry.

@tekknolagi, is this something you're willing to do?

@taleinat

taleinat commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

Never mind, I'll do it myself. This is a good fix for an obvious bug, and the tests are good, so I'd like to get this in.

@taleinat taleinat changed the title Fix incorrectly formatted _codecs.charmap_decode error message bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message Oct 17, 2020
taleinat
taleinat approved these changes Oct 17, 2020
View reviewed changes

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taleinat taleinat added needs backport to 3.8 type-bug An unexpected behavior, bug, or error labels Oct 17, 2020
@taleinat
taleinat merged commit 3635388 into python:master Oct 17, 2020
@miss-islington

miss-islington commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

Thanks @tekknolagi for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

bedevere-bot commented Oct 17, 2020

Copy link
Copy Markdown

GH-22743 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 17, 2020
@tekknolagi @miss-islington
bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error mes…
8ebc3ff 
…sage (pythonGH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 17, 2020
@tekknolagi @miss-islington
bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error mes…
bfa426c 
…sage (pythonGH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Oct 17, 2020

Copy link
Copy Markdown

GH-22744 is a backport of this pull request to the 3.8 branch.

@taleinat

taleinat commented Oct 17, 2020

Copy link
Copy Markdown
Contributor

Thanks for this PR, @tekknolagi!

@tekknolagi

tekknolagi commented Oct 17, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for adding the news entry, etc. I could not find the time nor the energy

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@tekknolagi @xzy3-cdc
bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error mes…
3721e74 
…sage (pythonGH-19940)
@taleinat

taleinat commented Oct 18, 2020

Copy link
Copy Markdown
Contributor

That's fine, @tekknolagi.

For future reference, blurb-it makes adding NEWS entries to PRs very easy.

taleinat pushed a commit that referenced this pull request Oct 18, 2020
@miss-islington @tekknolagi
bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error mes…
6a2aa49 
…sage (GH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
taleinat pushed a commit that referenced this pull request Oct 18, 2020
@miss-islington @tekknolagi
bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error mes…
400175a 
…sage (GH-19940)

(cherry picked from commit 3635388)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tekknolagi @adorilson
bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error mes…
2400d03 
…sage (pythonGH-19940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat taleinat approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tekknolagi @csabella @taleinat @miss-islington @bedevere-bot @the-knights-who-say-ni