Skip to content

bpo-40484: Document compiler flags under AST module#19885

Merged
pablogsal merged 5 commits into
python:masterfrom
isidentical:bpo-40484
Oct 19, 2020
Merged

bpo-40484: Document compiler flags under AST module#19885
pablogsal merged 5 commits into
python:masterfrom
isidentical:bpo-40484

Conversation

@isidentical

@isidentical isidentical commented May 3, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 3, 2020
@isidentical
isidentical requested a review from pablogsal May 3, 2020 14:13
pablogsal
pablogsal reviewed May 3, 2020
View reviewed changes
Comment thread Doc/library/ast.rst
hauntsaninja
hauntsaninja reviewed May 4, 2020
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small grammar nits! :-)

Comment thread Doc/library/ast.rst Outdated
Comment thread Doc/library/functions.rst Outdated
isidentical and others added 2 commits May 16, 2020 04:36
@isidentical @hauntsaninja
apply suggestions
859d310 
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
@isidentical @hauntsaninja
apply suggestions
bf04af9 
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
@isidentical

isidentical commented May 17, 2020

Copy link
Copy Markdown
Member Author

Two small grammar nits! :-)

Thanks @hauntsaninja!

@isidentical
isidentical requested a review from pablogsal May 17, 2020 02:08
pablogsal
pablogsal reviewed May 17, 2020
View reviewed changes
Comment thread Doc/library/ast.rst Outdated
pablogsal
pablogsal reviewed May 17, 2020
View reviewed changes
Comment thread Doc/library/ast.rst Outdated
@isidentical @pablogsal
Apply suggestions from code review
69d6c5f 
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@isidentical
isidentical requested a review from pablogsal May 22, 2020 00:05
@isidentical
isidentical requested a review from JulienPalard July 18, 2020 10:46
@taleinat

taleinat commented Oct 18, 2020

Copy link
Copy Markdown
Contributor

Ping, @pablogsal?

@pablogsal
pablogsal merged commit 1559389 into python:master Oct 19, 2020
@miss-islington

miss-islington commented Oct 19, 2020

Copy link
Copy Markdown
Contributor

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 19, 2020

Copy link
Copy Markdown

GH-22758 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2020
@isidentical @miss-islington
bpo-40484: Document compiler flags under AST module (pythonGH-19885)
a4df257 
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
(cherry picked from commit 1559389)

Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>
pablogsal pushed a commit that referenced this pull request Oct 19, 2020
@miss-islington @isidentical
bpo-40484: Document compiler flags under AST module (GH-19885) (GH-22758
a358a0a 
)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
(cherry picked from commit 1559389)

Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>

Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>
@rffontenelle

rffontenelle commented Oct 27, 2020

Copy link
Copy Markdown
Contributor

@isidentical Hey there. I notice the new strings for translation in library/functions and one changed raised doubts. The current line (first of a long paragraph):

The optional argument *flags* and *dont_inherit* controls which

replaced this previous line:

The optional arguments *flags* and *dont_inherit* control which

Link: https://github.com/python/cpython/blame/master/Doc/library/functions.rst#L262

Was this plural-to-singular change intentional? If yes, would you please clarify?

@isidentical

isidentical commented Oct 28, 2020

Copy link
Copy Markdown
Member Author

Was this plural-to-singular change intentional?

Looks like an oversight. Would you mind sending a PR to fix that?

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@isidentical @pablogsal
@hauntsaninja @adorilson
bpo-40484: Document compiler flags under AST module (pythonGH-19885)
29804aa 
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments
@pablogsal pablogsal pablogsal approved these changes
@JulienPalard JulienPalard Awaiting requested review from JulienPalard

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@isidentical @taleinat @miss-islington @bedevere-bot @rffontenelle @pablogsal @hauntsaninja @the-knights-who-say-ni