bpo-32604: Add support for a "default" arg in channel_recv().#19770
Merged
miss-islington merged 3 commits intopython:masterfrom Apr 28, 2020
Merged
bpo-32604: Add support for a "default" arg in channel_recv().#19770miss-islington merged 3 commits intopython:masterfrom
miss-islington merged 3 commits intopython:masterfrom
Conversation
nanjekyejoannah
approved these changes
Apr 28, 2020
Contributor
nanjekyejoannah
left a comment
nanjekyejoannah
left a comment
There was a problem hiding this comment.
Makes sense to me.
Contributor
|
@ericsnowcurrently: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the caller to avoid creation of an exception when the channel is empty (just like
dict.get()works).ChannelEmptyErroris still raised if no default is provided.https://bugs.python.org/issue32604
Automerge-Triggered-By: @ericsnowcurrently